feat(helm): Add health probes to loki in backend - #18548
Merged
Merged
Conversation
Signed-off-by: Andreas Lindhé <7773090+lindhe@users.noreply.github.com>
This change makes it possible to configure `livenessProbe` and `startupProbe` to the loki container in the backend pods. Also adds a guard for when the `readinessProbe` is unset. Signed-off-by: Andreas Lindhé <7773090+lindhe@users.noreply.github.com>
lindhe
force-pushed
the
loki-backend-healthprobes
branch
from
July 23, 2025 13:09
fb82597 to
4684a02
Compare
jkroepke
reviewed
Jul 23, 2025
jkroepke
left a comment
jkroepke
left a comment
Contributor
There was a problem hiding this comment.
Hi thanks for your PR. Please take note of my comments
Co-authored-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Andreas Lindhé <7773090+lindhe@users.noreply.github.com>
Co-authored-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Andreas Lindhé <7773090+lindhe@users.noreply.github.com>
Turns out some components (at least
templates/distributor/deployment-distributor.yaml)
was already using `.Values.loki.{livenessProbe,startupProbe}` despite
them being unset before.
So to be backwards compatible, I set them to null by default instead of
empty object.
jkroepke
reviewed
Jul 24, 2025
This reverts commit abe8bc2.
lindhe
commented
Jul 24, 2025
Contributor
|
hi @lindhe could you also do a merge from main, too? |
Signed-off-by: Andreas Lindhé <7773090+lindhe@users.noreply.github.com>
Signed-off-by: Andreas Lindhé <7773090+lindhe@users.noreply.github.com>
6 tasks
Contributor
Author
|
Great, thanks! Now that these PRs have all been merged, I'll add a bunch more PRs soon! Little by little, we are achieving #15359 💪 |
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change makes it possible to configure
livenessProbeandstartupProbeto the loki container in the backend pods. Also adds a guard for when thereadinessProbeis unset.Which issue(s) this PR fixes:
Partially addresses #13678
Special notes for your reviewer:
Partially replaces #15359
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR