feat(helm): Add health probes to bloom-planner - #18552
Merged
Merged
Conversation
jkroepke
reviewed
Jul 23, 2025
jkroepke
reviewed
Jul 28, 2025
lindhe
commented
Jul 30, 2025
Contributor
Signed-off-by: Andreas Lindhé <7773090+lindhe@users.noreply.github.com>
lindhe
force-pushed
the
bloom-planner-healthprobes
branch
from
August 15, 2025 17:01
f1a8cc8 to
3db8515
Compare
Adds configurable `livenessProbe` and `startupProbe` to the bloom-planner container in the bloom-planner pods. Signed-off-by: Andreas Lindhé <7773090+lindhe@users.noreply.github.com>
Done via the following command: ```shell docker run -it --rm -v "$(pwd):/go" --entrypoint bash -e BUILD_IN_CONTAINER=false grafana/loki-build-image:0.34.6 -c 'git config --global --add safe.directory /go; make -BC docs sources/setup/install/helm/reference.md' ``` Signed-off-by: Andreas Lindhé <7773090+lindhe@users.noreply.github.com>
lindhe
force-pushed
the
bloom-planner-healthprobes
branch
from
August 15, 2025 17:04
3db8515 to
fd5560c
Compare
Contributor
Author
|
Sorry for the delay, I'm on vacation. 😅 I've rebased the changes now, please review again as necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds configurable
livenessProbeandstartupProbeto the bloom-plannercontainer in the bloom-planner pods.
Which issue(s) this PR fixes:
Partially addresses #13678
Special notes for your reviewer:
Partially replaces #15359
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR