Skip to content

fix: routing for goldfish to work with nginx - #18578

Merged
trevorwhitney merged 1 commit into
mainfrom
fix-goldfish-ui-paths
Jul 24, 2025
Merged

fix: routing for goldfish to work with nginx#18578
trevorwhitney merged 1 commit into
mainfrom
fix-goldfish-ui-paths

Conversation

@trevorwhitney

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

The goldfish ui was not working correctly because of the subpath rewrite rule we have in the nginx used for the loki directory in front of it. That rule was only rewriting urls in html assets, and not handling fetch() calls. This PR fixes the fetch() calls used by goldfish to use the absolutePath() helper so urls are correctly rewritten for the nginx environment.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@trevorwhitney
trevorwhitney requested a review from a team as a code owner July 24, 2025 17:27
@trevorwhitney
trevorwhitney merged commit 2e728ce into main Jul 24, 2025
68 checks passed
@trevorwhitney
trevorwhitney deleted the fix-goldfish-ui-paths branch July 24, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants