feat: improve dataobj-inspect command - #18618
Merged
Merged
Conversation
grobinson-grafana
force-pushed
the
grobinson/improve-data-obj-inspect
branch
from
July 28, 2025 14:53
eb7c3b5 to
970db6d
Compare
grobinson-grafana
force-pushed
the
grobinson/improve-data-obj-inspect
branch
2 times, most recently
from
July 28, 2025 16:26
6c8602c to
eb96803
Compare
This commit improves the dataobj-inspect command to have two
sub-commands:
dump: Dumps the contents of each data object in file.
summary: Prints a summary of each data object in file.
grobinson-grafana
force-pushed
the
grobinson/improve-data-obj-inspect
branch
from
July 28, 2025 16:33
eb96803 to
6a74229
Compare
benclive
reviewed
Jul 29, 2025
benclive
left a comment
Contributor
There was a problem hiding this comment.
Nice! I'm happy to approve after the reader conditions are fixed. Thanks for implementing!
Another thought: It's not a blocker since this cmd is for debugging and I haven't actually used it myself, but the print streams command feels like it should be a stream-id filter on the dump command instead
| case logs.CheckSection(sec): | ||
| cmd.dumpLogsSection(context.TODO(), offset, sec) | ||
| default: | ||
| exitWithError(errors.New("unknown section")) |
Contributor
There was a problem hiding this comment.
Do we have the section metadata from sec? It might be nice to print "unknown section: X" instead of exiting completely on the first unknown section
benclive
approved these changes
Jul 29, 2025
benclive
left a comment
Contributor
There was a problem hiding this comment.
LGTM apart from one reader's if statement. Approving to unblock though.
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves the dataobj-inspect command to have two sub-commands:
Here is an example of how it looks:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR