Skip to content

feat(operator): Add alert LokiIngesterFlushFailureRateCritical - #18698

Merged
JoaoBraveCoding merged 5 commits into
grafana:mainfrom
JoaoBraveCoding:LOG-6238-2nd
Oct 1, 2025
Merged

feat(operator): Add alert LokiIngesterFlushFailureRateCritical#18698
JoaoBraveCoding merged 5 commits into
grafana:mainfrom
JoaoBraveCoding:LOG-6238-2nd

Conversation

@JoaoBraveCoding

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
A common but not immediately obvious way to misconfigure LokiStack is to provide it with a secret that is syntactically correct but invalid for accessing the object storage.

Which issue(s) this PR fixes:
Fixes https://issues.redhat.com/browse/LOG-6238

Special notes for your reviewer:
Needs #18696

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@JoaoBraveCoding

Copy link
Copy Markdown
Collaborator Author

Since the operator was updated to v3.5.4 we can now merge this

@JoaoBraveCoding
JoaoBraveCoding marked this pull request as ready for review September 5, 2025 11:17

@xperimental xperimental left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion for the query.

It took me a while to realize that the alert was not working in my test because this branch does not include the Loki update yet (a local merge fixed that though). 🙂

Comment thread operator/internal/manifests/internal/alerts/prometheus-alerts.yaml Outdated
Comment thread operator/internal/manifests/internal/alerts/prometheus-alerts.yaml Outdated

@JoaoBraveCoding JoaoBraveCoding left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the updates to the sop.md

@JoaoBraveCoding JoaoBraveCoding changed the title feat(operator): Add alert LokiIngesterCriticalFlushFailureRate Sep 30, 2025
@pull-request-size pull-request-size Bot added size/M and removed size/S labels Oct 1, 2025
@JoaoBraveCoding
JoaoBraveCoding force-pushed the LOG-6238-2nd branch 2 times, most recently from 1fe2000 to fdf0f3f Compare October 1, 2025 16:10
@JoaoBraveCoding
JoaoBraveCoding merged commit 66ebc5a into grafana:main Oct 1, 2025
111 of 141 checks passed
@JoaoBraveCoding
JoaoBraveCoding deleted the LOG-6238-2nd branch October 1, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants