Skip to content

feat(helm): allow configuring service types - #18708

Merged
Jayclifford345 merged 8 commits into
grafana:mainfrom
jkroepke:helm/service-type
Aug 27, 2025
Merged

feat(helm): allow configuring service types#18708
Jayclifford345 merged 8 commits into
grafana:mainfrom
jkroepke:helm/service-type

Conversation

@jkroepke

@jkroepke jkroepke commented Aug 3, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Allows the service type to be configured via values.yaml. In the case of an Ingress that relies on NodePort Services, the Ingress will not be able to reconcile, which can cause problems for other workloads sharing the Ingress group.

Which issue(s) this PR fixes:
Fixes #13028

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@jkroepke
jkroepke requested a review from a team as a code owner August 3, 2025 20:30
Comment thread production/helm/loki/values.yaml Outdated
@jkroepke

Copy link
Copy Markdown
Contributor Author

@QuentinBisson QuentinBisson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jayclifford345 Jayclifford345 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jayclifford345
Jayclifford345 merged commit 2e52f8f into grafana:main Aug 27, 2025
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants