Skip to content

fix: register goldfish flags - #18728

Merged
trevorwhitney merged 2 commits into
mainfrom
fix-goldfish-flag-registration
Aug 5, 2025
Merged

fix: register goldfish flags#18728
trevorwhitney merged 2 commits into
mainfrom
fix-goldfish-flag-registration

Conversation

@trevorwhitney

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Forgot to register these as command line flags.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@trevorwhitney
trevorwhitney requested a review from a team as a code owner August 5, 2025 21:23
@pull-request-size pull-request-size Bot added size/S and removed size/XS labels Aug 5, 2025
@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

💻 Deploy preview deleted.

@trevorwhitney
trevorwhitney merged commit e06fea9 into main Aug 5, 2025
68 checks passed
@trevorwhitney
trevorwhitney deleted the fix-goldfish-flag-registration branch August 5, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants