Skip to content

fix(helm): Removing deprecated admin_api_directory to avoid config crash - #18731

Merged
JStickler merged 6 commits into
grafana:mainfrom
sebastianplawner:fix-admin-api-directory
Aug 6, 2025
Merged

fix(helm): Removing deprecated admin_api_directory to avoid config crash#18731
JStickler merged 6 commits into
grafana:mainfrom
sebastianplawner:fix-admin-api-directory

Conversation

@sebastianplawner

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Prevents Loki from failing to start due to a deprecated admin_api_directory field in the Helm chart values. In recent Loki versions (≥3.5.x), this field is no longer recognized, causing a parsing error. This PR deletes the field to avoid breaking existing deployments relying on legacy configurations.

Which issue(s) this PR fixes:
Fixes #18729

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@sebastianplawner
sebastianplawner requested a review from a team as a code owner August 6, 2025 05:13
@CLAassistant

CLAassistant commented Aug 6, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Jayclifford345

Copy link
Copy Markdown
Contributor

Hey @sebastianplawner huge thank you for the quick fix. Would you mind running

make helm-docs

and pushing newly generated documentation that will clear up the workflow error

@Jayclifford345 Jayclifford345 self-assigned this Aug 6, 2025
@sebastianplawner

Copy link
Copy Markdown
Contributor Author

Hi @Jayclifford345, no problem at all. Thanks for reviewing my PR.

@Jayclifford345

Copy link
Copy Markdown
Contributor

Okay, running workflows again and then hopefull we can get this merged

@JStickler
JStickler merged commit 8cce03c into grafana:main Aug 6, 2025
78 checks passed
@jkroepke

jkroepke commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

@sebastianplawner thanks for providing a quick fix!

@sebastianplawner
sebastianplawner deleted the fix-admin-api-directory branch August 6, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 participants