fix(helm): Removing deprecated admin_api_directory to avoid config crash - #18731
Merged
Conversation
Contributor
|
Hey @sebastianplawner huge thank you for the quick fix. Would you mind running and pushing newly generated documentation that will clear up the workflow error |
Contributor
Author
|
Hi @Jayclifford345, no problem at all. Thanks for reviewing my PR. |
6 tasks
Contributor
|
Okay, running workflows again and then hopefull we can get this merged |
Jayclifford345
approved these changes
Aug 6, 2025
Contributor
|
@sebastianplawner thanks for providing a quick fix! |
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Prevents Loki from failing to start due to a deprecated admin_api_directory field in the Helm chart values. In recent Loki versions (≥3.5.x), this field is no longer recognized, causing a parsing error. This PR deletes the field to avoid breaking existing deployments relying on legacy configurations.
Which issue(s) this PR fixes:
Fixes #18729
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR