Skip to content

fix(helm): use gateway container port as nginx server port - #18774

Merged
Jayclifford345 merged 1 commit into
grafana:mainfrom
wind0r:gateway_containerport
Aug 27, 2025
Merged

fix(helm): use gateway container port as nginx server port#18774
Jayclifford345 merged 1 commit into
grafana:mainfrom
wind0r:gateway_containerport

Conversation

@wind0r

@wind0r wind0r commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
The current Helm chart allows you to change the container port for the gateway deployment, but then also the whole nginx config needs to be overwritten. With this change, nginxFile is using the containerPort, so nginx is using the correct port.

Which issue(s) this PR fixes:
Didn't create an issue for this

Special notes for your reviewer:
Nothing

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@wind0r
wind0r requested a review from a team as a code owner August 8, 2025 07:39
@CLAassistant

CLAassistant commented Aug 8, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@jkroepke jkroepke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

containerPort: {{ .Values.gateway.containerPort }}

Makes sense, LGTM!

@Jayclifford345
Jayclifford345 merged commit 84f7b8d into grafana:main Aug 27, 2025
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants