Skip to content

fix(helm): missing s3 field in lokiStorageConfig templated value - #18791

Merged
Jayclifford345 merged 3 commits into
grafana:mainfrom
peem5210:fix-(helm)-missing-s3-storage-config-in-helpers-template
Aug 14, 2025
Merged

fix(helm): missing s3 field in lokiStorageConfig templated value#18791
Jayclifford345 merged 3 commits into
grafana:mainfrom
peem5210:fix-(helm)-missing-s3-storage-config-in-helpers-template

Conversation

@peem5210

@peem5210 peem5210 commented Aug 10, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Omitting the s3 field in lokiStorageConfig prevents the Loki backend from connecting to external S3-compatible storage (e.g., MinIO or Ceph) because it’s used to render the common Loki configuration.

Which issue(s) this PR fixes:
Fixes #18790

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
Signed-off-by: peem5210 <47083240+peem5210@users.noreply.github.com>
@peem5210
peem5210 requested a review from a team as a code owner August 10, 2025 13:06
@CLAassistant

CLAassistant commented Aug 10, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Signed-off-by: peem5210 <47083240+peem5210@users.noreply.github.com>
@peem5210 peem5210 changed the title fix(helm): missing s3 in lokiStorageConfig template value Aug 10, 2025
Signed-off-by: peem5210 <47083240+peem5210@users.noreply.github.com>

@jkroepke jkroepke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, it's omit in 294 not available as as block.

LGTM

@peem5210

Copy link
Copy Markdown
Contributor Author

@jkroepke Thanks for the review and the LGTM! As a first-time Loki contributor, is there anything else needed from my side before this can be approved/merged?

@jkroepke

Copy link
Copy Markdown
Contributor

Hey @peem5210

CI is green, so currently looks good. We have a merge window each Monday for a limited count of PRs. If you PR is not merged today, it will be merged on next monday.

@Jayclifford345 Jayclifford345 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jayclifford345
Jayclifford345 merged commit d9e8e0f into grafana:main Aug 14, 2025
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment