fix(helm): missing s3 field in lokiStorageConfig templated value - #18791
Merged
Jayclifford345 merged 3 commits intoAug 14, 2025
Merged
Conversation
Signed-off-by: peem5210 <47083240+peem5210@users.noreply.github.com>
Signed-off-by: peem5210 <47083240+peem5210@users.noreply.github.com>
Signed-off-by: peem5210 <47083240+peem5210@users.noreply.github.com>
jkroepke
reviewed
Aug 11, 2025
jkroepke
left a comment
Contributor
There was a problem hiding this comment.
I see, it's omit in 294 not available as as block.
LGTM
Contributor
Author
|
@jkroepke Thanks for the review and the LGTM! As a first-time Loki contributor, is there anything else needed from my side before this can be approved/merged? |
Contributor
|
Hey @peem5210 CI is green, so currently looks good. We have a merge window each Monday for a limited count of PRs. If you PR is not merged today, it will be merged on next monday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Omitting the s3 field in lokiStorageConfig prevents the Loki backend from connecting to external S3-compatible storage (e.g., MinIO or Ceph) because it’s used to render the common Loki configuration.
Which issue(s) this PR fixes:
Fixes #18790
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR