Skip to content

feat(helm): add dnsconfig to all missing resources - #18903

Merged
Jayclifford345 merged 11 commits into
grafana:mainfrom
DrFaust92:dnsconfig
Sep 3, 2025
Merged

feat(helm): add dnsconfig to all missing resources#18903
Jayclifford345 merged 11 commits into
grafana:mainfrom
DrFaust92:dnsconfig

Conversation

@DrFaust92

@DrFaust92 DrFaust92 commented Aug 18, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@DrFaust92
DrFaust92 requested a review from a team as a code owner August 18, 2025 22:42
Comment thread production/helm/loki/templates/bloom-gateway/statefulset-bloom-gateway.yaml Outdated

@jkroepke jkroepke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add loki.dnsConfig to

https://github.com/grafana/loki/blob/main/production/helm/loki/ci/non-default-values.yaml

Consider something simple, which wont break the CI.

So it's part of the CI? Thanks.

@DrFaust92

Copy link
Copy Markdown
Contributor Author

Could you add loki.dnsConfig to

https://github.com/grafana/loki/blob/main/production/helm/loki/ci/non-default-values.yaml

Consider something simple, which wont break the CI.

So it's part of the CI? Thanks.

Yes, added a case for default and and an override one of the components

@jkroepke jkroepke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. if ci is green.

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>

@Jayclifford345 Jayclifford345 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
@Jayclifford345
Jayclifford345 enabled auto-merge (squash) September 3, 2025 09:32
Signed-off-by: J Stickler <julie.stickler@grafana.com>
@Jayclifford345
Jayclifford345 merged commit ed68531 into grafana:main Sep 3, 2025
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants