feat(logcli): add --log.level parameter - #19136
Merged
Merged
Conversation
To help with diagnosing errors when using logcli.
Contributor
|
💻 Deploy preview deleted. |
Contributor
Author
I did read that page and tried to follow its advice. Are scopes not allowed? |
slim-bean
approved these changes
Sep 9, 2025
Collaborator
|
I guess the syntax is a bit different, feat(logcli) vs feat[logcli] |
Contributor
Author
|
Thanks, I now see the confusion. In the summary |
It's OK to ignore the error because `logLevel` is constrained to be one of the accepted values.
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To help with diagnosing errors when using logcli.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
It feels a little ugly to pull in
dskitreferences in a command-line program. Open to any suggestions of other ways to do it.Also I'm not sure if the default setting of
errorwill log anything new that users don't want to see.Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR