Skip to content

feat(helm): Add startupProbe to memcached - #19166

Merged
Jayclifford345 merged 3 commits into
grafana:mainfrom
lindhe:memcached-healthprobes
Oct 9, 2025
Merged

feat(helm): Add startupProbe to memcached#19166
Jayclifford345 merged 3 commits into
grafana:mainfrom
lindhe:memcached-healthprobes

Conversation

@lindhe

@lindhe lindhe commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This change makes it possible to configure startupProbe to the memcached container in the memcached pods.

Which issue(s) this PR fixes:

Not sure.

Special notes for your reviewer:

Partially replaces #15359

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@lindhe
lindhe requested a review from a team as a code owner September 11, 2025 07:19
@lindhe
lindhe force-pushed the memcached-healthprobes branch 2 times, most recently from 30c023e to 5ef788a Compare September 11, 2025 07:20

@jkroepke jkroepke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please update the branch as well!

This change makes it possible to configure `startupProbe` to the
memcached container in the memcached pods.

Signed-off-by: Andreas Lindhé <7773090+lindhe@users.noreply.github.com>
@lindhe
lindhe force-pushed the memcached-healthprobes branch from 5ef788a to fa08f7d Compare October 7, 2025 10:49
Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
@Jayclifford345
Jayclifford345 enabled auto-merge (squash) October 9, 2025 08:41

@Jayclifford345 Jayclifford345 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jayclifford345
Jayclifford345 merged commit f799e9b into grafana:main Oct 9, 2025
75 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants