feat(single-binary): delete statefulset if volumeClaimTemplates changes - #19217
Merged
JStickler merged 1 commit intoOct 15, 2025
Merged
Conversation
cwrau
force-pushed
the
feat/single-binary/delete-statefulset-on-size-change
branch
from
September 19, 2025 07:27
b2dc1dd to
9e54465
Compare
Contributor
Author
|
I tried running |
cwrau
force-pushed
the
feat/single-binary/delete-statefulset-on-size-change
branch
from
September 26, 2025 10:26
9e54465 to
2cc495e
Compare
Contributor
Author
|
|
cwrau
force-pushed
the
feat/single-binary/delete-statefulset-on-size-change
branch
from
September 26, 2025 11:45
2cc495e to
7ae4a6c
Compare
cwrau
force-pushed
the
feat/single-binary/delete-statefulset-on-size-change
branch
from
September 29, 2025 08:13
7ae4a6c to
8a4da25
Compare
jkroepke
reviewed
Sep 29, 2025
cwrau
force-pushed
the
feat/single-binary/delete-statefulset-on-size-change
branch
from
September 30, 2025 12:28
8a4da25 to
18dd3c0
Compare
jkroepke
reviewed
Sep 30, 2025
jkroepke
left a comment
Contributor
There was a problem hiding this comment.
In generell, interresting feature! I may consider to integrate this at kube prometheus stack as well.
However a bit more docs are needed, since its an heavy feature.
cwrau
force-pushed
the
feat/single-binary/delete-statefulset-on-size-change
branch
3 times, most recently
from
October 1, 2025 08:01
9b3ac28 to
55a597e
Compare
Jayclifford345
enabled auto-merge (squash)
October 15, 2025 10:31
This makes resizing loki gitops friendly
auto-merge was automatically disabled
October 15, 2025 10:38
Head branch was pushed to by a user without write access
cwrau
force-pushed
the
feat/single-binary/delete-statefulset-on-size-change
branch
from
October 15, 2025 10:38
a5e1023 to
e2ad356
Compare
Contributor
Author
|
Sorry, during testing I missed that the PVC needs to be patched as well 😕 |
3 tasks
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes resizing loki gitops friendly
What this PR does / why we need it:
Currently resizing loki requires manual intervention.
This PR makes it possible to resize loki without manual intervention,
by orphan-deleting the statefulset which helm then recreates.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR