fix: add single-binary component to ingress NetworkPolicy - #19229
Merged
JStickler merged 3 commits intoOct 15, 2025
Conversation
- Include 'single-binary' in NetworkPolicy podSelector when gateway is disabled - Allows traffic from Alloy to Loki pods in single-binary deployment mode - Fixes NetworkPolicy not matching single-binary component pods Fixes grafana#19199 Signed-off-by: puretension <rlrlfhtm5@gmail.com>
jkroepke
reviewed
Oct 7, 2025
Jayclifford345
enabled auto-merge (squash)
October 15, 2025 09:51
JStickler
disabled auto-merge
October 15, 2025 18:25
6 tasks
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes NetworkPolicy in single-binary deployment mode by adding
single-binarycomponent to the podSelector. This allows traffic from Alloy to reach Loki pods when deployed in single-binary mode without gateway.Which issue(s) this PR fixes:
Fixes #19199
Special notes for your reviewer:
Single line fix that adds
single-binaryto the component values list when gateway is disabled. This ensures NetworkPolicy correctly matches single-binary pods.Checklist
CONTRIBUTING.mdguide (required)docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory.