Skip to content

fix(helm): explicitly set registry for k8s-sidecar image - #19233

Merged
Jayclifford345 merged 3 commits into
grafana:mainfrom
yellowhat:main
Sep 24, 2025
Merged

fix(helm): explicitly set registry for k8s-sidecar image#19233
Jayclifford345 merged 3 commits into
grafana:mainfrom
yellowhat:main

Conversation

@yellowhat

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

I am getting:

Failed to inspect image "": rpc error: code = Unknown desc = short name mode is enforcing, but image name kiwigrid/k8s-sidecar:1.30.7 returns ambiguous list

probable due to crio 1.34.0, but better to be explicit.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@yellowhat
yellowhat requested a review from a team as a code owner September 19, 2025 08:59
@CLAassistant

CLAassistant commented Sep 19, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@jkroepke jkroepke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please add fix(helm) as PR prefix. And leave a CHANGELOG note.

@yellowhat yellowhat changed the title fix: explicity set registry for k8s-sidecar image Sep 21, 2025
@yellowhat yellowhat changed the title fix(helm): explicity set registry for k8s-sidecar image Sep 21, 2025
@yellowhat

Copy link
Copy Markdown
Contributor Author

Done can you check now?

@jkroepke jkroepke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yellowhat and others added 3 commits September 23, 2025 17:43
Signed-off-by: yellowhat <1692490+yellowhat@users.noreply.github.com>
Signed-off-by: yellowhat <1692490+yellowhat@users.noreply.github.com>
Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
@Jayclifford345
Jayclifford345 merged commit e0c07c4 into grafana:main Sep 24, 2025
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants