Skip to content

fix: revoke partitions if lost - #20030

Merged
grobinson-grafana merged 1 commit into
mainfrom
grobinson/revoke-partitions-if-lost
Nov 26, 2025
Merged

fix: revoke partitions if lost#20030
grobinson-grafana merged 1 commit into
mainfrom
grobinson/revoke-partitions-if-lost

Conversation

@grobinson-grafana

@grobinson-grafana grobinson-grafana commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This commit fixes a bug where pods would keep hold of partitions that they had lost instead of revoking them. This would happen, for example, if the clients session failed with the broker.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
This commit fixes a bug where pods would keep hold of partitions
that they had lost instead of revoking them. This would happen,
for example, if the clients session failed with the broker.
@grobinson-grafana
grobinson-grafana requested a review from a team as a code owner November 26, 2025 10:09
@grobinson-grafana
grobinson-grafana merged commit 1ac5d1f into main Nov 26, 2025
68 checks passed
@grobinson-grafana
grobinson-grafana deleted the grobinson/revoke-partitions-if-lost branch November 26, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants