Skip to content

fix: Restrict start/end timestamp to requested range for scheduler - #20086

Merged
benclive merged 3 commits into
mainfrom
benclive/fix-start-end-timestamp-for-query-splits
Dec 2, 2025
Merged

fix: Restrict start/end timestamp to requested range for scheduler#20086
benclive merged 3 commits into
mainfrom
benclive/fix-start-end-timestamp-for-query-splits

Conversation

@benclive

@benclive benclive commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
The query-frontend was adjusting the query start/end times beyond the original request, which meant additional datapoints are included when they would previously be excluded. I believe this affects both log & metric queries.

I continued to allow the internal split to be step aligned, but then replaced the start/end times of the total range with the originally requested ones so the query never exceeds the original bounds.

@benclive
benclive requested a review from a team as a code owner December 2, 2025 13:48
Comment thread pkg/querier/queryrange/engine_router.go

@ashwanthgoli ashwanthgoli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benclive
benclive enabled auto-merge (squash) December 2, 2025 17:28
@benclive
benclive merged commit 448cc74 into main Dec 2, 2025
125 of 173 checks passed
@benclive
benclive deleted the benclive/fix-start-end-timestamp-for-query-splits branch December 2, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants