Skip to content

feat: add rules check for namespace and group - #20437

Merged
DylanGuedes merged 6 commits into
mainfrom
check-against-characters-rules-path
Jan 15, 2026
Merged

feat: add rules check for namespace and group#20437
DylanGuedes merged 6 commits into
mainfrom
check-against-characters-rules-path

Conversation

@DylanGuedes

@DylanGuedes DylanGuedes commented Jan 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Add an extra check to our rules-related endpoints to make sure a given namespace and group are local.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@pull-request-size pull-request-size Bot added size/M and removed size/L labels Jan 15, 2026
@DylanGuedes
DylanGuedes force-pushed the check-against-characters-rules-path branch from 03927fb to 915a43f Compare January 15, 2026 13:18
@pull-request-size pull-request-size Bot added size/S and removed size/M labels Jan 15, 2026
@DylanGuedes
DylanGuedes force-pushed the check-against-characters-rules-path branch from 17d3b5e to e0256f9 Compare January 15, 2026 22:22
@DylanGuedes DylanGuedes changed the title add check against special chars Jan 15, 2026
@DylanGuedes
DylanGuedes marked this pull request as ready for review January 15, 2026 23:08
@DylanGuedes
DylanGuedes requested a review from a team as a code owner January 15, 2026 23:08
@DylanGuedes
DylanGuedes merged commit 9f5d215 into main Jan 15, 2026
70 of 71 checks passed
@DylanGuedes
DylanGuedes deleted the check-against-characters-rules-path branch January 15, 2026 23:29
shantanualsi pushed a commit that referenced this pull request Jan 16, 2026
@DylanGuedes @shantanualsi
feat: add rules check for namespace and group (#20437)
af48fb7
@shantanualsi shantanualsi mentioned this pull request Jan 16, 2026
Merged
6 tasks
shantanualsi added a commit that referenced this pull request Jan 19, 2026
@shantanualsi @DylanGuedes
feat: add rules check for namespace and group (#20437) (#20463)
7733ab1 
Co-authored-by: Dylan Guedes <djmgguedes@gmail.com>
@loki-gh-app loki-gh-app Bot mentioned this pull request Jan 19, 2026
Merged
@BrewTestBot BrewTestBot mentioned this pull request Jan 21, 2026
Merged
This was referenced Mar 30, 2026
Closed
Merged
This was referenced Jun 23, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M

2 participants

@DylanGuedes @paul1r