fix(loki/single-binary): Add missing command to statefulset-recreate-job

[marvinWolff]

What this PR does / why we need it:

When the recreate Job is created it fails, because of the missing kubectl.

Special notes for your reviewer:

Checklist

• Reviewed the CONTRIBUTING.md guide (required)
• Documentation added
• Tests updated
• Title matches the required conventional commits format, see here
  • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
• Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
• If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

[CLAassistant]

All committers have signed the CLA.

[cwrau]

Ou, damn, must've missed that 😕

[marvinWolff]

Is there something i need to do before this can be merged? :)

[JStickler]

Hi @marvinWolff Right now the Loki Helm Chart is sort of in limbo. The Loki Helm Community maintainers launched the Grafana-community/helm-charts on January 30th, and are planning to fork the Loki Helm Chart to the new repo on March 16th. I’ll see if I can get someone’s attention to take a look at your PR.

[TheRealNoob]

Spent a little time recreating a values file and managed to figure out what's happened. This Job uses the image docker.io/rancher/kubectl:v1.33.0 which has the entrypoint/cmd of the following

$ docker image inspect docker.io/rancher/kubectl:v1.33.0
<snip>
            "Cmd": [
                "help"
            ],
            "Entrypoint": [
                "/bin/kubectl"

The "issue" is that the Job is defining command which is overriding the entrypoint. I believe the Job intended to use args which overrides the arguments to the entrypoint. @marvinWolff would you mind please changing the PR to reflect this? I know both solutions would work.

command in Kubernetes ≈ ENTRYPOINT in Docker.
args in Kubernetes ≈ CMD in Docker.

[TheRealNoob]

can you also make an entry in production/helm/loki/CHANGELOG.md‎ please

[jkroepke]

Hi @marvinWolff thanks for your PR. Please adjust the CHANGELOG as well.

[marvinWolff]

Sorry for the late reply.

I added the changes.

[TheRealNoob]

LGTM