feat: add loki health command (backport release-3.6.x) - #20590
Merged
Conversation
(cherry picked from commit ef69cfd)
salvacorts
approved these changes
Jan 28, 2026
|
FYI this documentation still needs updating: |
Contributor
|
@NanoTrasen-Inc thanks, should be fixed now. |
antonio-mazzini
added a commit
to antonio-mazzini/tempo
that referenced
this pull request
Mar 4, 2026
Add a -health CLI flag that checks Tempo's /ready endpoint without requiring a config file or shell in the container. This enables native Docker HEALTHCHECK using the Tempo binary itself, which is important since the distroless base image has no shell or curl. Usage: tempo -health [-health.url=http://localhost:3200/ready] Follows the same pattern adopted in Loki (grafana/loki#20590).
oleg-kozlyuk-grafana
pushed a commit
to grafana/tempo
that referenced
this pull request
Mar 10, 2026
* feat: add -health flag for Docker healthchecks Add a -health CLI flag that checks Tempo's /ready endpoint without requiring a shell in the container. This enables native Docker HEALTHCHECK using the Tempo binary itself, which is important since the distroless base image has no shell or curl. Usage: tempo -health [-health.url=http://localhost:3200/ready] Follows the same pattern adopted in Loki (grafana/loki#20590). * refactor: use standard flag package for health check
mattdurham
pushed a commit
to mattdurham/tempo
that referenced
this pull request
Jun 18, 2026
* feat: add -health flag for Docker healthchecks Add a -health CLI flag that checks Tempo's /ready endpoint without requiring a shell in the container. This enables native Docker HEALTHCHECK using the Tempo binary itself, which is important since the distroless base image has no shell or curl. Usage: tempo -health [-health.url=http://localhost:3200/ready] Follows the same pattern adopted in Loki (grafana/loki#20590). * refactor: use standard flag package for health check
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport ef69cfd from #20313
What this PR does / why we need it:
Since we are using the distroless docker image, we don't have shell and tools to execute the healthcheck when starting loki.
For some cases we can run a sidecar, kube is calling the ready endpoint.
But in cases that are not these two, like docker swarm, it is not possible to make a check.
So we are adding a health command support to the binary, where the user can call the binary with the
-healtharg, this will make Loki check itself without any external dependency or shell needed in docker container.Which issue(s) this PR fixes:
Fixes #20149
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR