fix(dataobj): Avoid deadlock in index-builder when cancelling mid-build - #20621
Merged
Conversation
benclive
commented
Jan 30, 2026
| case obj = <-si.downloadedObjects: | ||
| downloadRequestsPending-- | ||
| case <-ctx.Done(): | ||
| return "", processed, ctx.Err() |
Contributor
Author
There was a problem hiding this comment.
I think this early return is the cause. Returning here will stop reading from the downloadedObjects channel, despite us writing len(events) to it in the previous for-loop.
Nothing else reads from the downloadedObjects channel, and it has a small buffer to avoid having too many objects in memory at any one time. The next build could fill the input downloadQueue with events, block, and never be able to proceed to reading from this channel.
grobinson-grafana
approved these changes
Jan 30, 2026
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixing a deadlock that can occur in the index-builder if the build context is cancelled mid-build.