fix(helm): ignore dots after first path segment when detecting image registry - #20695
Merged
JStickler merged 7 commits intoMar 10, 2026
Conversation
Contributor
Author
|
@Jayclifford345 are you the right one to tag for a review? It's my first contribution so if there is anything missing just let me know :) |
Contributor
|
Hi @Bastizeit Right now the Loki Helm Chart is sort of in limbo. The Loki Helm Community maintainers launched the Grafana-community/helm-charts on January 30th, and are planning to fork the Loki Helm Chart to the new repo on March 16th. I’ll see if I can get someone’s attention to take a look at your PR. |
Signed-off-by: Bastizeit <54327601+Bastizeit@users.noreply.github.com>
Contributor
Author
|
@JStickler @jkroepke I'm curious if there is anything missing to merge the change in? |
Signed-off-by: J Stickler <julie.stickler@grafana.com>
JStickler
approved these changes
Mar 10, 2026
1 task
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
What:
The Helm chart’s image builder currently decides “repository already includes a registry” by checking for a . anywhere in the repository string. This incorrectly treats repositories like mirrored/docker.io/grafana/loki as already fully-qualified, so the configured registry (e.g. private.registry.com) is not prefixed.
Why:
Users who mirror upstream images under a path containing docker.io (or similar) commonly set:
image.registry: private.registry.com
image.repository: mirrored/docker.io/...
Today that results in images being rendered without the private registry prefix, causing pulls to fail or to hit the wrong registry.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR