fix(helm): apply trafficDistribution setting to SingleBinary service - #20894
Merged
JStickler merged 7 commits intoMar 10, 2026
Conversation
…ingleBinary-service
…ingleBinary-service
…ingleBinary-service
…ingleBinary-service
…ingleBinary-service Signed-off-by: J Stickler <julie.stickler@grafana.com>
JStickler
approved these changes
Mar 10, 2026
This was referenced Mar 23, 2026
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
singleBinary.service.trafficDistributionvalue was documented invalues.yamlbut never applied to the SingleBinary Service template,causing the setting to be silently ignored.
This PR adds the same
trafficDistributionrendering that already existsin the Write, Read, Backend, and other service templates.
Both
singleBinary.service.trafficDistributionand the global fallbackloki.service.trafficDistributionare now respected.Which issue(s) this PR fixes:
Fixes #20428
Special notes for your reviewer:
One-line addition following the exact same pattern used in
templates/write/service-write.yaml(and read, backend, etc.).Checklist
CONTRIBUTING.mdguide (required)