Skip to content

fix(helm): apply trafficDistribution setting to SingleBinary service - #20894

Merged
JStickler merged 7 commits into
grafana:mainfrom
railgun-0402:feature/apply-trafficDistribution-setting--SingleBinary-service
Mar 10, 2026
Merged

fix(helm): apply trafficDistribution setting to SingleBinary service#20894
JStickler merged 7 commits into
grafana:mainfrom
railgun-0402:feature/apply-trafficDistribution-setting--SingleBinary-service

Conversation

@railgun-0402

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
The singleBinary.service.trafficDistribution value was documented in
values.yaml but never applied to the SingleBinary Service template,
causing the setting to be silently ignored.

This PR adds the same trafficDistribution rendering that already exists
in the Write, Read, Backend, and other service templates.
Both singleBinary.service.trafficDistribution and the global fallback
loki.service.trafficDistribution are now respected.

Which issue(s) this PR fixes:
Fixes #20428

Special notes for your reviewer:
One-line addition following the exact same pattern used in
templates/write/service-write.yaml (and read, backend, etc.).

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
@railgun-0402
railgun-0402 requested a review from a team as a code owner February 20, 2026 14:34
@CLAassistant

CLAassistant commented Feb 20, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@TheRealNoob TheRealNoob left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc @JStickler

@JStickler
JStickler merged commit bceabc3 into grafana:main Mar 10, 2026
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants