fix(operator): properly handle the deprecation of replicationFactor - #20935
Merged
Conversation
btaani
requested review from
a team,
JoaoBraveCoding,
periklis and
xperimental
as code owners
February 23, 2026 18:24
JoaoBraveCoding
left a comment
JoaoBraveCoding
left a comment
Collaborator
There was a problem hiding this comment.
Just the linting that was failing, otherwise works 👍
xperimental
reviewed
Feb 24, 2026
xperimental
left a comment
xperimental
left a comment
Collaborator
There was a problem hiding this comment.
Just one small comment.
JoaoBraveCoding
approved these changes
Feb 25, 2026
JoaoBraveCoding
left a comment
JoaoBraveCoding
left a comment
Collaborator
There was a problem hiding this comment.
From my side lgtm
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The deprecated field,
replicationFactor, was handled in the wrong part of the code, which makes it ignored when set in the LokiStack CR and not applying toreplication.Factor. This PR moves this handling to where it should be.Which issue(s) this PR fixes:
Fixes LOG-8795
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR