perf(tsdb): don't fetch labels in TSDBIndex.GetChunkRefs - #20970
Merged
Conversation
This lets the function under test perform best. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Also stop passing chks parameter which is unused. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Unless necessary for filtering. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
paul1r
approved these changes
Feb 25, 2026
bboreham
added a commit
to bboreham/loki
that referenced
this pull request
Feb 26, 2026
This is the same change as grafana#20969, missed from grafana#20970 by accident. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
trevorwhitney
pushed a commit
that referenced
this pull request
May 15, 2026
sophiewaldman
pushed a commit
that referenced
this pull request
May 15, 2026
This was referenced May 20, 2026
This was referenced Jun 8, 2026
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I noticed in a profile from production that index-gateways were spending a lot of time reading labels, in a context where labels are not typically needed.
This PR is made up of a refactoring to simplify the change, then adding the possibility to not fetch labels, and finally changing
GetChunkRefsto only fetch labels when it needs to. It may need labels for series filtering, which is used by some downstream projects.The benchmark results are not impressive, because
BenchmarkTSDBIndex_GetChunkRefsonly creates three series.Still, a 30% drop in objects allocated shows that something was achieved.
I fixed the benchmark to return memory to the pool, otherwise that dominates.
Checklist
CONTRIBUTING.mdguide (required)docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory.