fix: Preserve caching options after query split - #21320
Merged
Merged
Conversation
This was referenced Apr 20, 2026
This was referenced May 20, 2026
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Preserves the Caching options for LokiRequest objects through the splitting middleware.
Cache-Control: no-cacheheader work as expected for queries that get split.Note
Low Risk
Small, localized change that only copies an existing field into split sub-requests; behavior impact is limited to caching controls on split queries.
Overview
Preserves per-request
CachingOptionswhen query splitting creates sub-requests, so cache-control settings (e.g. no-cache) are not lost after splitting.This updates the splitter factories for
LokiRequest(both default and metric query splitters) andlogproto.VolumeRequestto copyCachingOptions, and adds a unit test ensuring splitLokiRequests retain the original caching configuration.Written by Cursor Bugbot for commit 56237ef. This will update automatically on new commits. Configure here.