fix: Fix ruler panic related to unset validation scheme - #21400
Merged
Conversation
trevorwhitney
approved these changes
Apr 3, 2026
loki-gh-app Bot
pushed a commit
that referenced
this pull request
Apr 3, 2026
(cherry picked from commit a5bd996)
This was referenced Apr 3, 2026
This was referenced Apr 20, 2026
This was referenced May 20, 2026
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Without the change in
notifier.go, we receive the following stack trace from this test:This stack trace is on par with the one seen in this Loki issue.
After the change to
notifier.go, the test passes.Which issue(s) this PR fixes:
Fixes #21368
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PRNote
Medium Risk
Touches ruler alert notification configuration by forcing
MetricNameValidationSchemetoUTF8, which could subtly affect label validation/relabeling behavior but is narrowly scoped and covered by new tests.Overview
Fixes a ruler alert-delivery panic by ensuring the synthetic Prometheus notifier config always sets
GlobalConfig.MetricNameValidationSchemetomodel.UTF8Validation, preventingnotifier.ApplyConfigfrom propagating an unset scheme intoalert_relabel_configs.Updates notifier config unit test expectations accordingly and adds targeted tests that (1) assert the scheme is set and (2) reproduce the previously panicking
relabel.Replace+Sendpath to ensure it no longer panics.Written by Cursor Bugbot for commit 62e6565. This will update automatically on new commits. Configure here.