Skip to content

feat: Remove task_pruning_cache_fetch_batch_size in favor of existing memcached batching - #21593

Merged
salvacorts merged 3 commits into
mainfrom
salvacorts/remove-TaskPruningCacheFetchBatchSize
Apr 17, 2026
Merged

feat: Remove task_pruning_cache_fetch_batch_size in favor of existing memcached batching#21593
salvacorts merged 3 commits into
mainfrom
salvacorts/remove-TaskPruningCacheFetchBatchSize

Conversation

@salvacorts

@salvacorts salvacorts commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Removing the new config introduced in #21548

Since we already have the memcached batchsize param. Which was actually preventing anny efective batching though task_pruning_cache_fetch_batch_size.

BatchSize int `yaml:"batch_size"`

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Note

Medium Risk
Removes configurable batching for cache lookups during plan-time empty-task pruning and switches to a single Fetch call per cache name, which could change cache load/performance characteristics for large plans depending on backend behavior.

Overview
Removes the experimental task_pruning_cache_fetch_batch_size configuration/flag and its documentation.

Plan-time pruning of empty cached tasks now performs a single cache Fetch per cache name (no explicit key batching), drops the associated batching plumbing in workflow options/planner, and deletes the batching-focused unit test.

Reviewed by Cursor Bugbot for commit 134cd4b. Bugbot is set up for automated code reviews on this repo. Configure here.

@salvacorts
salvacorts requested a review from a team as a code owner April 17, 2026 09:47
@pull-request-size pull-request-size Bot added size/L and removed size/M labels Apr 17, 2026
@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

💻 Deploy preview deleted (feat: Remove task_pruning_cache_fetch_batch_size in favor of existing memcached batching).

@salvacorts
salvacorts merged commit 24ca0e4 into main Apr 17, 2026
94 checks passed
@salvacorts
salvacorts deleted the salvacorts/remove-TaskPruningCacheFetchBatchSize branch April 17, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants