feat: Remove task_pruning_cache_fetch_batch_size in favor of existing memcached batching - #21593
Merged
salvacorts merged 3 commits intoApr 17, 2026
Merged
Conversation
… memcached batching
Contributor
|
💻 Deploy preview deleted (feat: Remove task_pruning_cache_fetch_batch_size in favor of existing memcached batching). |
benclive
approved these changes
Apr 17, 2026
This was referenced Apr 20, 2026
This was referenced May 20, 2026
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removing the new config introduced in #21548
Since we already have the memcached
batchsizeparam. Which was actually preventing anny efective batching thoughtask_pruning_cache_fetch_batch_size.loki/pkg/storage/chunk/cache/memcached.go
Line 25 in 8509f1d
Checklist
CONTRIBUTING.mdguide (required)docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PRNote
Medium Risk
Removes configurable batching for cache lookups during plan-time empty-task pruning and switches to a single
Fetchcall per cache name, which could change cache load/performance characteristics for large plans depending on backend behavior.Overview
Removes the experimental
task_pruning_cache_fetch_batch_sizeconfiguration/flag and its documentation.Plan-time pruning of empty cached tasks now performs a single cache
Fetchper cache name (no explicit key batching), drops the associated batching plumbing inworkflowoptions/planner, and deletes the batching-focused unit test.Reviewed by Cursor Bugbot for commit 134cd4b. Bugbot is set up for automated code reviews on this repo. Configure here.