chore(ksonnet)!: Remove boltdb-shipper specific flags from lib - #21656
Merged
Conversation
chaudum
commented
Apr 22, 2026
| @@ -0,0 +1,95 @@ | |||
| { | |||
Contributor
Author
There was a problem hiding this comment.
Moved here from shipper.libsonnet
chaudum
commented
Apr 22, 2026
|
|
||
| _config+:: { | ||
| // run rulers as statefulsets when using boltdb-shipper to avoid using node disk for storing the index. | ||
| stateful_rulers: if self.using_boltdb_shipper && !self.use_index_gateway then true else super.stateful_rulers, |
Contributor
Author
There was a problem hiding this comment.
self.using_boltdb_shipper && !self.use_index_gateway always resolves to false
…ecific flags from lib
chaudum
marked this pull request as ready for review
April 22, 2026 10:10
Contributor
|
💻 Deploy preview deleted (chore(ksonnet)!: Remove boltdb-shipper specific flags from lib). |
This was referenced Apr 27, 2026
This was referenced May 20, 2026
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With the removal of deprecated storage backends, the Loki jsonnet library is also cleaned up to reflect these changes. Affected configuration flags are:
$._config.using_shipper_store- any usages defaulted totrue$._config.using_boltdb_shipper- any usages defaulted tofalse$._config.using_tsdb_shipper- any usages defaulted totrueThis change may update both command line arguments and the Loki config. If you've been using or overriding one of the three aforementioned configuration options, please remove them and replace them with the new defaults.
Note
Medium Risk
This is a breaking change for Jsonnet/Tanka users who relied on
using_*shippertoggles or BoltDB-shipper-specific behavior; it alters generated Loki args/manifests (shipper, compactor, ruler, index-gateway) and may change runtime config if overrides were in use.Overview
Drops non-TSDB store support in the ksonnet Jsonnet lib by removing
$._config.using_shipper_store,using_boltdb_shipper, andusing_tsdb_shipperand simplifyingshipper.libsonnetto always configuretsdb_shipper(and defaultstateful_querierswhen no index-gateway).Refactors compactor deployment out of
shipper.libsonnetinto a newcompactor.libsonnetand wires it intoloki.libsonnet, including optional horizontal-scaling worker support.Removes BoltDB-shipper wiring elsewhere:
index-gateway.libsonnetno longer configuresboltdb_shipperclient settings, andruler.libsonnetdrops BoltDB-shipper-specific cache flags/stateful defaults.Documentation and examples are updated to reflect the breaking change and to use newer defaults (example bumps Loki image to
3.7.1and switches schema totsdb/v13).Reviewed by Cursor Bugbot for commit 27f71b0. Bugbot is set up for automated code reviews on this repo. Configure here.