fix: Use KafkaWriter in dataobj-tee - #21732
Merged
Merged
Conversation
This commit uses the KafkaWriter in the dataobj-tee so both topics use the same limits in pkg/kafka/client/writer_client.go. In future, we will deprecate the limits from writer_client.go and use MaxBufferedBytes instead, since twmb/franz-go/issues/777 has been fixed.
rfratto
approved these changes
Apr 29, 2026
sophiewaldman
pushed a commit
that referenced
this pull request
May 15, 2026
This was referenced May 20, 2026
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit uses the KafkaWriter in the dataobj-tee so both topics use the same limits in
pkg/kafka/client/writer_client.go.In future, we will deprecate the limits from
writer_client.goand useMaxBufferedBytesinstead, since twmb/franz-go/issues/777 has been fixed.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PRNote
Medium Risk
Touches the distributor write path to Kafka by changing the producer type and
ProduceSynccall signature; behavior should be equivalent but miswiring could break or alter tee writes under load.Overview
The data-object tee now writes via the distributor’s shared
KafkaProducer(kafkaWriter) instead of using a dedicated*kgo.Client, so both Kafka topics follow the same writer limits/configuration.This updates
DataObjTee/NewDataObjTeeto acceptKafkaProducerand adjusts theProduceSyncinvocation to match the producer API.Reviewed by Cursor Bugbot for commit 6dfdc5c. Bugbot is set up for automated code reviews on this repo. Configure here.