chore!: Rename metric loki_log_flushes - #21765
Merged
Merged
Conversation
Rename metric `loki_log_flushes` to `loki_internal_log_flushes` to be consistent with `loki_internal_log_messages_total`.
Contributor
|
💻 Deploy preview deleted (chore!: Rename metric |
sophiewaldman
pushed a commit
that referenced
this pull request
May 15, 2026
Rename metric loki_log_flushes to loki_internal_log_flushes to be consistent with loki_internal_log_messages_total.
This was referenced May 20, 2026
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename metric
loki_log_flushestoloki_internal_log_flushesto be consistent withloki_internal_log_messages_total.Note
Medium Risk
Medium risk because it’s a breaking Prometheus metric rename that will break existing dashboards/alerts unless updated; runtime behavior is otherwise unchanged.
Overview
Renames the buffered logger flush histogram metric from
loki_log_flushestoloki_internal_log_flushesinpkg/util/log/log.goto align with theloki_internal_*naming scheme.Updates the upgrade guide to document the metric rename as a breaking change so operators can adjust dashboards/alerts accordingly.
Reviewed by Cursor Bugbot for commit d192758. Bugbot is set up for automated code reviews on this repo. Configure here.