fix: Partial acceptance of records in ProduceSync - #21781
Merged
grobinson-grafana merged 2 commits intoMay 7, 2026
Conversation
This commit fixes situations where some records in a batch can be accepted, but not others. For example, consider a limit of 1KB, and records of size 512B, 513B and 256B. In this case, records 1 and 3 will be accepted, and 2 will be rejected. In most cases, this results in retries, and duplication of data. This change means that the entire batch is rejected if any records exceed the limit.
grobinson-grafana
deleted the
grobinson/enforce-limit-on-all-records-produce-sync
branch
May 7, 2026 07:20
sophiewaldman
pushed a commit
that referenced
this pull request
May 15, 2026
This was referenced May 20, 2026
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit fixes situations where some records in a batch can be accepted, but not others. For example, consider a limit of 1KB, and records of size 512B, 513B and 256B. In this case, records 1 and 3 will be accepted, and 2 will be rejected. In most cases, this results in retries, and duplication of data. This change means that the entire batch is rejected if any records exceed the limit.
Same fix in Mimir: grafana/mimir#15227
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PRNote
Medium Risk
Changes producer backpressure behavior by failing an entire batch when the buffered-bytes limit would be exceeded, which could affect ingestion under load. Logic is localized and covered by a new unit test, keeping overall risk moderate.
Overview
Producer.ProduceSyncnow enforces the buffered-bytes limit atomically per batch: it sums record sizes up-front and, if the batch would exceedmaxBufferedBytes, it fails all records withkgo.ErrMaxBufferedinstead of partially accepting some.Adds a test ensuring oversized batches are fully rejected and that the same records succeed when produced individually.
Reviewed by Cursor Bugbot for commit ac8701b. Bugbot is set up for automated code reviews on this repo. Configure here.