chore!: Remove deprecated `allow_deletes` configuration option by chaudum · Pull Request #21808 · grafana/loki

chaudum · 2026-05-11T12:43:44Z

Summary

The -compactor.allow-deletes was already deprecated and unused and only logged a warning.

Note

Medium Risk
Removes a previously accepted config field/flag (allow_deletes), which can cause startup/config-validation failures for deployments still setting it, but the runtime behavior was already controlled by deletion_mode.

Overview
Removes the deprecated allow_deletes delete toggle by deleting the limits_config.allow_deletes YAML field and the -compactor.allow-deletes CLI flag (and associated warning/validation code), leaving limits_config.deletion_mode as the supported control.

Updates upgrade docs to call out the breaking change, and adjusts the deprecated-config checker to treat allow_deletes as deleted/invalid (including test fixtures and delete lists).

^{Reviewed by Cursor Bugbot for commit 32d6451. Bugbot is set up for automated code reviews on this repo. Configure here.}

github-actions · 2026-05-11T12:45:42Z

💻 Deploy preview available (chore!: Remove deprecated allow_deletes limit):

https://deploy-preview-loki-21808-zb444pucvq-vp.a.run.app/docs/loki/latest/

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Autofix Details

Bugbot Autofix prepared a fix for the issue found in the latest run.

✅ Fixed: Removed option still classified as deprecated, not deleted
- Moved allow_deletes from deprecated to deleted checker config and updated the checker test expectations and fixtures accordingly.

Or push these changes by commenting:

@cursor push 95c3c4a482

Preview (95c3c4a482)

diff --git a/tools/deprecated-config-checker/checker/checker_test.go b/tools/deprecated-config-checker/checker/checker_test.go
--- a/tools/deprecated-config-checker/checker/checker_test.go
+++ b/tools/deprecated-config-checker/checker/checker_test.go
@@ -36,6 +36,7 @@
 		"compactor.shared_store_key_prefix",
 		"limits_config.enforce_metric_name",
 		"limits_config.ruler_evaluation_delay_duration",
+		"limits_config.allow_deletes",
 	}
 
 	expectedConfigDeprecates = []string{
@@ -64,7 +65,6 @@
 		"limits_config.ruler_remote_write_sigv4_config",
 		"limits_config.per_tenant_override_config",
 		"limits_config.per_tenant_override_period",
-		"limits_config.allow_deletes",
 		"schema_config.configs.[1].store",
 		"schema_config.configs.[1].object_store",
 		"schema_config.configs.[2].store",
@@ -86,8 +86,10 @@
 	expectedRuntimeConfigDeletes = []string{
 		"overrides.foo.ruler_evaluation_delay_duration",
 		"overrides.foo.enforce_metric_name",
+		"overrides.foo.allow_deletes",
 		"overrides.bar.ruler_evaluation_delay_duration",
 		"overrides.bar.enforce_metric_name",
+		"overrides.bar.allow_deletes",
 	}
 
 	expectedRuntimeConfigDeprecates = []string{
@@ -107,7 +109,6 @@
 		"overrides.foo.ruler_remote_write_sigv4_config",
 		"overrides.foo.per_tenant_override_config",
 		"overrides.foo.per_tenant_override_period",
-		"overrides.foo.allow_deletes",
 		"overrides.bar.unordered_writes",
 		"overrides.bar.ruler_remote_write_url",
 		"overrides.bar.ruler_remote_write_timeout",
@@ -124,7 +125,6 @@
 		"overrides.bar.ruler_remote_write_sigv4_config",
 		"overrides.bar.per_tenant_override_config",
 		"overrides.bar.per_tenant_override_period",
-		"overrides.bar.allow_deletes",
 	}
 )
 

diff --git a/tools/deprecated-config-checker/deleted-config.yaml b/tools/deprecated-config-checker/deleted-config.yaml
--- a/tools/deprecated-config-checker/deleted-config.yaml
+++ b/tools/deprecated-config-checker/deleted-config.yaml
@@ -50,3 +50,4 @@
 limits_config:
   ruler_evaluation_delay_duration: "This setting is removed."
   enforce_metric_name: "This setting is removed."
+  allow_deletes: "Use deletion_mode per tenant configuration instead."

diff --git a/tools/deprecated-config-checker/deprecated-config.yaml b/tools/deprecated-config-checker/deprecated-config.yaml
--- a/tools/deprecated-config-checker/deprecated-config.yaml
+++ b/tools/deprecated-config-checker/deprecated-config.yaml
@@ -65,7 +65,6 @@
   ruler_remote_write_sigv4_config: "Use ruler_remote_write_config instead."
   per_tenant_override_config: "Feature renamed to 'runtime configuration', flag deprecated in favor of runtime_config.file"
   per_tenant_override_period: "Feature renamed to 'runtime configuration', flag deprecated in favor of runtime_config.period"
-  allow_deletes: "Use deletion_mode per tenant configuration instead."
 
 server:
   grpc_server_stats_tracking_enabled: "Deprecated, currently doesn't do anything, will be removed in a future version."
\ No newline at end of file

diff --git a/tools/deprecated-config-checker/test-fixtures/config.yaml b/tools/deprecated-config-checker/test-fixtures/config.yaml
--- a/tools/deprecated-config-checker/test-fixtures/config.yaml
+++ b/tools/deprecated-config-checker/test-fixtures/config.yaml
@@ -136,4 +136,4 @@
     region: "wherever"
   per_tenant_override_config: ./overrides.yaml # DEPRECATED
   per_tenant_override_period: 5s # DEPRECATED
-  allow_deletes: true # DEPRECATED
+  allow_deletes: true # DELETED

diff --git a/tools/deprecated-config-checker/test-fixtures/runtime-config.yaml b/tools/deprecated-config-checker/test-fixtures/runtime-config.yaml
--- a/tools/deprecated-config-checker/test-fixtures/runtime-config.yaml
+++ b/tools/deprecated-config-checker/test-fixtures/runtime-config.yaml
@@ -20,7 +20,7 @@
       region: "wherever"
     per_tenant_override_config: ./overrides.yaml # DEPRECATED
     per_tenant_override_period: 5s # DEPRECATED
-    allow_deletes: true # DEPRECATED
+    allow_deletes: true # DELETED
   "bar": *tenant_overrides
 
 multi_kv_config:

_{You can send follow-ups to the cloud agent here.}

chaudum · 2026-05-11T13:16:33Z

@cursor push 95c3c4a

cla-assistant · 2026-05-11T13:17:14Z

All committers have signed the CLA.

github-actions · 2026-05-11T13:18:28Z

💻 Deploy preview deleted (chore!: Remove deprecated allow_deletes configuration option).

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Autofix Details

Bugbot Autofix prepared fixes for both issues found in the latest run.

✅ Fixed: Test fixture missing entry expected by test assertion
- Restored the config fixture's limits_config.allow_deletes entry as a deleted option so the checker can report the expected deletion.
✅ Fixed: Orphaned deprecated CLI flag registration not removed
- Removed the lingering compactor.allow-deletes deprecated flag registration so the removed CLI option is no longer accepted.

Or push these changes by commenting:

@cursor push 45fd138486

Preview (45fd138486)

diff --git a/pkg/validation/limits.go b/pkg/validation/limits.go
--- a/pkg/validation/limits.go
+++ b/pkg/validation/limits.go
@@ -498,9 +498,6 @@
 
 	f.StringVar(&l.DeletionMode, "compactor.deletion-mode", "filter-and-delete", "Deletion mode. Can be one of 'disabled', 'filter-only', or 'filter-and-delete'. When set to 'filter-only' or 'filter-and-delete', and if retention_enabled is true, then the log entry deletion API endpoints are available.")
 
-	// Deprecated
-	dskit_flagext.DeprecatedFlag(f, "compactor.allow-deletes", "Deprecated. Instead, see compactor.deletion-mode which is another per tenant configuration", util_log.Logger)
-
 	f.IntVar(&l.IndexGatewayShardSize, "index-gateway.shard-size", 0, "The shard size defines how many index gateways should be used by a tenant for querying. If the global shard factor is 0, the global shard factor is set to the deprecated -replication-factor for backwards compatibility reasons.")
 	f.Float64Var(&l.IndexGatewayMaxCapacity, "index-gateway.max-capacity", 1.0, "Experimental. Defines a fraction (between 0.0 and 1.0) of the total index gateways available for a each tenant. A value of 0.0 has the same effect as 1.0, meaning all available index gateways. This setting only applies to simple mode.")
 

diff --git a/tools/deprecated-config-checker/test-fixtures/config.yaml b/tools/deprecated-config-checker/test-fixtures/config.yaml
--- a/tools/deprecated-config-checker/test-fixtures/config.yaml
+++ b/tools/deprecated-config-checker/test-fixtures/config.yaml
@@ -136,3 +136,4 @@
     region: "wherever"
   per_tenant_override_config: ./overrides.yaml # DEPRECATED
   per_tenant_override_period: 5s # DEPRECATED
+  allow_deletes: true # DELETED

_{You can send follow-ups to the cloud agent here.}

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Autofix Details

Bugbot Autofix prepared a fix for the issue found in the latest run.

✅ Fixed: Removed config not added to deleted-config registry
- Added allow_deletes to the deleted config registry and restored checker fixtures and expectations so config and runtime-config usages warn as deleted.

Or push these changes by commenting:

@cursor push 6ca293ec39

Preview (6ca293ec39)

diff --git a/tools/deprecated-config-checker/checker/checker_test.go b/tools/deprecated-config-checker/checker/checker_test.go
--- a/tools/deprecated-config-checker/checker/checker_test.go
+++ b/tools/deprecated-config-checker/checker/checker_test.go
@@ -34,6 +34,7 @@
 		"compactor.deletion_mode",
 		"compactor.shared_store",
 		"compactor.shared_store_key_prefix",
+		"limits_config.allow_deletes",
 		"limits_config.enforce_metric_name",
 		"limits_config.ruler_evaluation_delay_duration",
 	}
@@ -83,8 +84,10 @@
 	}
 
 	expectedRuntimeConfigDeletes = []string{
+		"overrides.foo.allow_deletes",
 		"overrides.foo.ruler_evaluation_delay_duration",
 		"overrides.foo.enforce_metric_name",
+		"overrides.bar.allow_deletes",
 		"overrides.bar.ruler_evaluation_delay_duration",
 		"overrides.bar.enforce_metric_name",
 	}

diff --git a/tools/deprecated-config-checker/deleted-config.yaml b/tools/deprecated-config-checker/deleted-config.yaml
--- a/tools/deprecated-config-checker/deleted-config.yaml
+++ b/tools/deprecated-config-checker/deleted-config.yaml
@@ -48,5 +48,6 @@
   max_look_back_period: "Use global or per-tenant max_query_lookback configuration from limits_config."
 
 limits_config:
+  allow_deletes: "Use deletion_mode per tenant configuration instead."
   ruler_evaluation_delay_duration: "This setting is removed."
   enforce_metric_name: "This setting is removed."

diff --git a/tools/deprecated-config-checker/test-fixtures/config.yaml b/tools/deprecated-config-checker/test-fixtures/config.yaml
--- a/tools/deprecated-config-checker/test-fixtures/config.yaml
+++ b/tools/deprecated-config-checker/test-fixtures/config.yaml
@@ -117,6 +117,7 @@
 
 limits_config:
   ingestion_rate_mb: 100
+  allow_deletes: true # DELETED
   unordered_writes: true # DEPRECATED
   enforce_metric_name: true # DELETED
   ruler_evaluation_delay_duration: 1m # DELETED

diff --git a/tools/deprecated-config-checker/test-fixtures/runtime-config.yaml b/tools/deprecated-config-checker/test-fixtures/runtime-config.yaml
--- a/tools/deprecated-config-checker/test-fixtures/runtime-config.yaml
+++ b/tools/deprecated-config-checker/test-fixtures/runtime-config.yaml
@@ -1,6 +1,7 @@
 overrides:
   "foo": &tenant_overrides
     ingestion_rate_mb: 100
+    allow_deletes: true # DELETED
     unordered_writes: true # DEPRECATED
     enforce_metric_name: true # DELETED
     ruler_evaluation_delay_duration: 1m # DELETED

_{You can send follow-ups to the cloud agent here.}

JStickler

[docs team] Docs LGTM

… limit

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

✅ Fixed: Missing entries in expected runtime config deletes list
- Added the missing foo and bar allow_deletes runtime delete expectations so the checker test matches deleted-config.yaml.

Or push these changes by commenting:

@cursor push 3cf42ac5f4

Preview (3cf42ac5f4)

diff --git a/tools/deprecated-config-checker/checker/checker_test.go b/tools/deprecated-config-checker/checker/checker_test.go
--- a/tools/deprecated-config-checker/checker/checker_test.go
+++ b/tools/deprecated-config-checker/checker/checker_test.go
@@ -86,8 +86,10 @@
 	expectedRuntimeConfigDeletes = []string{
 		"overrides.foo.ruler_evaluation_delay_duration",
 		"overrides.foo.enforce_metric_name",
+		"overrides.foo.allow_deletes",
 		"overrides.bar.ruler_evaluation_delay_duration",
 		"overrides.bar.enforce_metric_name",
+		"overrides.bar.allow_deletes",
 	}
 
 	expectedRuntimeConfigDeprecates = []string{

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 862d1d6. Configure here.}

…eletes` limit

chaudum requested a review from a team as a code owner May 11, 2026 12:43

pull-request-size Bot added the size/S label May 11, 2026

chaudum changed the title ~~chore!: Remove deprecated allow_deletes limit~~ May 11, 2026

paul1r previously approved these changes May 11, 2026

View reviewed changes

cursor Bot reviewed May 11, 2026

View reviewed changes

Comment thread pkg/validation/limits.go

cursor Bot dismissed paul1r’s stale review via 0588154 May 11, 2026 13:16

chaudum force-pushed the chaudum/remove-allow-deletes branch from 59dce36 to bbd0402 Compare May 11, 2026 13:20

cursor Bot reviewed May 11, 2026

View reviewed changes

Comment thread tools/deprecated-config-checker/test-fixtures/config.yaml

Comment thread pkg/validation/limits.go

paul1r previously approved these changes May 11, 2026

View reviewed changes

chaudum dismissed paul1r’s stale review via 63214f4 May 11, 2026 13:34

chaudum enabled auto-merge (squash) May 11, 2026 13:34

cursor Bot reviewed May 11, 2026

View reviewed changes

Comment thread tools/deprecated-config-checker/deprecated-config.yaml

JStickler reviewed May 11, 2026

View reviewed changes

chaudum added 4 commits May 12, 2026 09:57

chore!: Remove deprecated allow_deletes limit

e01f5c3

fixup! chore!: Remove deprecated allow_deletes limit

80cc9b8

fixup! fixup! chore!: Remove deprecated allow_deletes limit

b8a8f6b

fixup! fixup! fixup! chore!: Remove deprecated allow_deletes limit

cd447fc

chaudum force-pushed the chaudum/remove-allow-deletes branch from 63214f4 to cd447fc Compare May 12, 2026 08:08

pull-request-size Bot added size/M and removed size/S labels May 12, 2026

fixup! fixup! fixup! fixup! chore!: Remove deprecated allow_deletes…

862d1d6

… limit

cursor Bot reviewed May 12, 2026

View reviewed changes

Comment thread tools/deprecated-config-checker/checker/checker_test.go

salvacorts previously approved these changes May 12, 2026

View reviewed changes

fixup! fixup! fixup! fixup! fixup! chore!: Remove deprecated `allow_d…

32d6451

…eletes` limit

chaudum dismissed salvacorts’s stale review via 32d6451 May 12, 2026 08:53

salvacorts approved these changes May 12, 2026

View reviewed changes

chaudum merged commit eb17156 into main May 12, 2026
85 checks passed

chaudum deleted the chaudum/remove-allow-deletes branch May 12, 2026 09:10

sophiewaldman pushed a commit that referenced this pull request May 15, 2026

chore!: Remove deprecated allow_deletes configuration option (#21808)

942755c

This was referenced May 20, 2026

chore(k307): release 3.8.0 #21968

Closed

chore(k308): release 3.8.0 #22007

Closed

loki-gh-app Bot mentioned this pull request Jun 1, 2026

chore(k309): release 3.8.0 #22136

Closed

This was referenced Jun 8, 2026

chore(k310): Release 3.8.0 #22294

Merged

chore(k310): Release 3.8.0 (backport main) #22303

Merged

chore(k310): Release 3.9.0 #22317

Closed

chore(k311): Release 3.9.0 #22415

Open

loki-gh-app Bot mentioned this pull request Jun 22, 2026

chore(k312): Release 3.9.0 #22492

Open

loki-gh-app Bot mentioned this pull request Jun 29, 2026

chore(k313): Release 3.9.0 #22761

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore!: Remove deprecated `allow_deletes` configuration option - #21808

chore!: Remove deprecated `allow_deletes` configuration option#21808
chaudum merged 6 commits into
mainfrom
chaudum/remove-allow-deletes

chaudum commented May 11, 2026 •

edited by cursor Bot

Loading

github-actions Bot commented May 11, 2026

cursor Bot left a comment •

edited

Loading

Uh oh!

chaudum commented May 11, 2026

cla-assistant Bot commented May 11, 2026 •

edited

Loading

github-actions Bot commented May 11, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

cursor Bot left a comment •

edited

Loading

Uh oh!

JStickler left a comment

cursor Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Labels

4 participants

Uh oh!

Conversation

chaudum commented May 11, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

github-actions Bot commented May 11, 2026

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chaudum commented May 11, 2026

cla-assistant Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

github-actions Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JStickler left a comment

Choose a reason for hiding this comment

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Labels

4 participants

chaudum commented May 11, 2026 •

edited by cursor Bot

Loading

cursor Bot left a comment •

edited

Loading

cla-assistant Bot commented May 11, 2026 •

edited

Loading

github-actions Bot commented May 11, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading