chore!: Remove deprecated per-tenant setting unordered_writes - #21835
Merged
Conversation
The setting `unordered_writes` was deprecated and defaulted to `true`. Now it has been removed. Please use the `deprecated-config-checker` tool to validate your `config.yaml`.
Contributor
|
💻 Deploy preview deleted (chore!: Remove deprecated per-tenant setting |
![cursor[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Unused function
headBlockTypeleft as dead code- Removed the unreferenced private
headBlockTypehelper frompkg/ingester/stream.go.
- Removed the unreferenced private
Or push these changes by commenting:
@cursor push 775a784284
Preview (775a784284)
diff --git a/pkg/ingester/stream.go b/pkg/ingester/stream.go
--- a/pkg/ingester/stream.go
+++ b/pkg/ingester/stream.go
@@ -645,15 +645,6 @@
s.tailers[t.getID()] = t
}
-func headBlockType(chunkfmt byte, unorderedWrites bool) chunkenc.HeadBlockFmt {
- if unorderedWrites {
- if chunkfmt >= chunkenc.ChunkFormatV3 {
- return chunkenc.ChunkHeadFormatFor(chunkfmt)
- }
- }
- return chunkenc.OrderedHeadBlockFmt
-}
-
func labelsEqual(a, b pushtypes.LabelsAdapter) bool {
if len(a) != len(b) {
return falseYou can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit 1721b6e. Configure here.
JStickler
reviewed
May 12, 2026
| The `too_far_behind` validation error is returned when lines in question are older than half of `-ingester.max-chunk-age` compared to the newest line in the stream. | ||
|
|
||
| This validation error is returned when a stream is submitted out of order. More details can be found [here](/docs/loki/<LOKI_VERSION>/configuration/#accept-out-of-order-writes) about the Loki ordering constraints. | ||
| This problem can be solved by ensuring that log delivery is configured correctly. |
Contributor
There was a problem hiding this comment.
"is configured correctly" isn't very helpful. Can we restore the link to #accept out of order writes please?
Contributor
There was a problem hiding this comment.
Or explain what "configured correctly" looks like with an example?
Contributor
Author
There was a problem hiding this comment.
I think I need to remove the section "Accept out-of-order writes" from the configuration page, since it references the now removed setting.
Contributor
Author
There was a problem hiding this comment.
Ok, so I updated the "Accept out-of-order writes" section and keep the link on this page.
JStickler
reviewed
May 12, 2026
JStickler
reviewed
May 12, 2026
Co-authored-by: J Stickler <julie.stickler@grafana.com> Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
ashwanthgoli
previously approved these changes
May 13, 2026
Co-authored-by: Ashwanth <iamashwanth@gmail.com> Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
enabled auto-merge (squash)
May 13, 2026 07:39
salvacorts
approved these changes
May 13, 2026
sophiewaldman
pushed a commit
that referenced
this pull request
May 15, 2026
The setting unordered_writes was deprecated and defaulted to true. Now it has been removed. Please use the deprecated-config-checker tool to validate your config.yaml. Signed-off-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: J Stickler <julie.stickler@grafana.com> Co-authored-by: Ashwanth <iamashwanth@gmail.com>
This was referenced May 20, 2026
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The setting
unordered_writeswas deprecated and defaulted totrue. Now it has been removed.Please use the
deprecated-config-checkertool to validate yourconfig.yaml.Note
Medium Risk
Removes a previously user-configurable ingestion behavior and changes validation/metric labeling around out-of-order data, which can affect upgrade compatibility and operational alerting.
Overview
Loki no longer supports configuring
unordered_writes(global or per-tenant): the limit/CLI flag and override plumbing are removed, stream creation no longer carries anunorderedWritesmode, and WAL recovery no longer includes logic to convert unordered→ordered head blocks.Ingestion validation is simplified to always enforce the
max_chunk_age/2cutoff for old entries and to always report discards asreason=too_far_behind(removingout_of_order), with docs and troubleshooting guidance updated and thedeprecated-config-checkerupdated to flaglimits_config.unordered_writesand per-tenant override usage as removed.Reviewed by Cursor Bugbot for commit 4722a23. Bugbot is set up for automated code reviews on this repo. Configure here.