Skip to content

fix(mixin): Fix regex pattern for compactor job matcher - #22004

Merged
chaudum merged 1 commit into
grafana:mainfrom
jkroepke:patch-2
May 29, 2026
Merged

fix(mixin): Fix regex pattern for compactor job matcher#22004
chaudum merged 1 commit into
grafana:mainfrom
jkroepke:patch-2

Conversation

@jkroepke

@jkroepke jkroepke commented May 23, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

With quotes, it results into job=~\"($namespace)/\"(.*compactor|.*-backend.*|loki-single-binary)\"\", which is wrong.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@jkroepke
fix(mixin): regex pattern for compactor job matcher
e538e9e 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke
jkroepke requested a review from a team as a code owner May 23, 2026 17:14
@chaudum chaudum changed the title fix(mixin): regex pattern for compactor job matcher May 29, 2026
chaudum
chaudum approved these changes May 29, 2026
View reviewed changes

@chaudum chaudum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@chaudum
chaudum enabled auto-merge (squash) May 29, 2026 15:34
@chaudum
chaudum merged commit 4fa6c79 into grafana:main May 29, 2026
83 of 84 checks passed
@loki-gh-app loki-gh-app Bot mentioned this pull request Jun 1, 2026
Closed
@jkroepke
jkroepke deleted the patch-2 branch June 1, 2026 06:36
This was referenced Jun 8, 2026
Merged
Merged
Closed
zwmyxzs pushed a commit to zwmyxzs/loki that referenced this pull request Jun 12, 2026
@jkroepke @zwmyxzs
fix(mixin): Fix regex pattern for compactor job matcher (grafana#22004)
08b089d 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
This was referenced Jun 15, 2026
Open
Open
@loki-gh-app loki-gh-app Bot mentioned this pull request Jun 29, 2026
Open
This was referenced Jul 13, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jkroepke @chaudum