Skip to content

fix(dataobj): Handle constant predicates in logs predicate ordering - #22160

Merged
benclive merged 1 commit into
mainfrom
paul1r/true_false_predicate_support
Jun 3, 2026
Merged

fix(dataobj): Handle constant predicates in logs predicate ordering#22160
benclive merged 1 commit into
mainfrom
paul1r/true_false_predicate_support

Conversation

@paul1r

@paul1r paul1r commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

DataObjScan can map engine filters to dataset.TruePredicate and
dataset.FalsePredicate, but getPredicateSelectivity panicked when
orderPredicates scored them. Return fixed selectivity for constants so
impossible filters no longer crash queriers during reader init.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@paul1r
paul1r requested a review from a team as a code owner June 2, 2026 18:20
@benclive
benclive merged commit 5c0197c into main Jun 3, 2026
89 checks passed
@benclive
benclive deleted the paul1r/true_false_predicate_support branch June 3, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants