Skip to content

fix(ci): Remove test checking for nfpm vars, like main - #22501

Merged
paul1r merged 2 commits into
release-3.7.xfrom
paul1r/remove_nfpm
Jun 22, 2026
Merged

fix(ci): Remove test checking for nfpm vars, like main#22501
paul1r merged 2 commits into
release-3.7.xfrom
paul1r/remove_nfpm

Conversation

@paul1r

@paul1r paul1r commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
To fix the error seen here
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@paul1r
paul1r requested a review from a team as a code owner June 22, 2026 14:35
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ The workflow jobs listed below don't declare a permissions: block and may break when the organization's default GITHUB_TOKEN permissions are restricted to read-only.

Expand for findings
warning[excessive-permissions]: overly broad permissions
   --> ./.github/workflows/helm-ci.yml:2:1
    |
  2 | / name: helm-ci
  3 | | on:
  4 | |   pull_request:
  5 | |     paths:
...   |
220 | |           DEBUG: ${{ runner.debug == '1' && 'true' || 'false' }}
221 | |           VERBOSE: ${{ runner.debug == '1' && 'true' || 'false' }}
    | |___________________________________________________________________^ default permissions used due to no permissions: block
    |
    = note: audit confidence → Medium
    = help: audit documentation → https://docs.zizmor.sh/audits/#excessive-permissions

warning[excessive-permissions]: overly broad permissions
   --> ./.github/workflows/helm-ci.yml:93:3
    |
 93 | /   list-integration-tests:
 94 | |     name: List integration tests
 95 | |     runs-on: ubuntu-latest
 96 | |     outputs:
...   |
111 | |           echo "Tests: ${tests}"
112 | |           echo "tests=$(echo "${tests}" | jq --raw-input --slurp --compact-output 'split("\n") | map(select(. != ""))')" >> "${GITHUB_OUTPUT}"
    | |                                                                                                                                              ^
    | |                                                                                                                                              |
    | |______________________________________________________________________________________________________________________________________________this job
    |                                                                                                                                                default permissions used due to no permissions: block
    |
    = note: audit confidence → Medium
    = help: audit documentation → https://docs.zizmor.sh/audits/#excessive-permissions

warning[excessive-permissions]: overly broad permissions
   --> ./.github/workflows/helm-ci.yml:114:3
    |
114 | /   run-integration-tests:
115 | |     name: Integration Test
116 | |     needs: list-integration-tests
117 | |     runs-on: ubuntu-latest
...   |
220 | |           DEBUG: ${{ runner.debug == '1' && 'true' || 'false' }}
221 | |           VERBOSE: ${{ runner.debug == '1' && 'true' || 'false' }}
    | |                                                                   ^
    | |                                                                   |
    | |___________________________________________________________________this job
    |                                                                     default permissions used due to no permissions: block
    |
    = note: audit confidence → Medium
    = help: audit documentation → https://docs.zizmor.sh/audits/#excessive-permissions

warning[excessive-permissions]: overly broad permissions
  --> ./.github/workflows/operator-images.yaml:1:1
   |
 1 | / name: operator images
 2 | |
 3 | | on:
 4 | |   push:
...  |
45 | |       image_name: "storage-size-calculator"
46 | |       tag: "latest"
   | |____________________^ default permissions used due to no permissions: block
   |
   = note: audit confidence → Medium
   = help: audit documentation → https://docs.zizmor.sh/audits/#excessive-permissions

warning[excessive-permissions]: overly broad permissions
  --> ./.github/workflows/operator-images.yaml:12:3
   |
12 | /   publish-grafana-operator:
13 | |     uses: ./.github/workflows/operator-reusable-image-build.yml
14 | |     with:
15 | |       dockerfile: "operator/Dockerfile"
...  |
18 | |       image_name: "loki-operator"
19 | |       tag: "latest"
   | |                   ^
   | |                   |
   | |___________________this job
   |                     default permissions used due to no permissions: block
   |
   = note: audit confidence → Medium
   = help: audit documentation → https://docs.zizmor.sh/audits/#excessive-permissions

warning[excessive-permissions]: overly broad permissions
  --> ./.github/workflows/operator-images.yaml:21:3
   |
21 | /   publish-openshift-operator:
22 | |     uses: ./.github/workflows/operator-reusable-image-build.yml
23 | |     with:
24 | |       dockerfile: "operator/Dockerfile"
...  |
27 | |       image_name: "loki-operator"
28 | |       tag: "latest"
   | |                   ^
   | |                   |
   | |___________________this job
   |                     default permissions used due to no permissions: block
   |
   = note: audit confidence → Medium
   = help: audit documentation → https://docs.zizmor.sh/audits/#excessive-permissions

warning[excessive-permissions]: overly broad permissions
  --> ./.github/workflows/operator-images.yaml:30:3
   |
30 | /   publish-openshift-bundle:
31 | |     uses: ./.github/workflows/operator-reusable-image-build.yml
32 | |     with:
33 | |       dockerfile: "operator/bundle/openshift/bundle.Dockerfile"
...  |
36 | |       image_name: "loki-operator-bundle"
37 | |       tag: "latest"
   | |                   ^
   | |                   |
   | |___________________this job
   |                     default permissions used due to no permissions: block
   |
   = note: audit confidence → Medium
   = help: audit documentation → https://docs.zizmor.sh/audits/#excessive-permissions

warning[excessive-permissions]: overly broad permissions
  --> ./.github/workflows/operator-images.yaml:39:3
   |
39 | /   publish-openshift-size-calculator:
40 | |     uses: ./.github/workflows/operator-reusable-image-build.yml
41 | |     with:
42 | |       dockerfile: "operator/calculator.Dockerfile"
...  |
45 | |       image_name: "storage-size-calculator"
46 | |       tag: "latest"
   | |                    ^
   | |                    |
   | |____________________this job
   |                      default permissions used due to no permissions: block
   |
   = note: audit confidence → Medium
   = help: audit documentation → https://docs.zizmor.sh/audits/#excessive-permissions
@paul1r
paul1r merged commit 5f48f39 into release-3.7.x Jun 22, 2026
82 checks passed
@paul1r
paul1r deleted the paul1r/remove_nfpm branch June 22, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants