-
Notifications
You must be signed in to change notification settings - Fork 20
feat: add indicator when there is an error with per-check alerts #1148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I was a little bit confused because I see that we are showing the error next to the alert in the "alerts pop-up". But IIRC, this alerts pop-up is populated from the alerts that are already created, because these are queried through some alerting endpoint. So how are we doing that for the case on which an alert has been set up for a check, but this one is not created in the stack, for example due to a quota limit error? |
b8bd0e5
to
8c49b21
Compare
You have a good point. I made some changes so now the UI always displays per-check alerts, even if the corresponding alert rule does not exist in the alerting endpoint response. In the screenshot below, the |
09f2538
to
3ec1940
Compare
That looks great! Thanks 🙌 |
Ensure UI can display alert status/errors for alerts not present in the stack
3ec1940
to
8522657
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #1131
With the new per-check alerts, the creation request can be successful but there can still be asynchronous errors that need to be displayed to the user. This PR addresses this requirement.
From https://github.com/grafana/synthetic-monitoring/issues/266:
NOTE: in order to see the error messages, the app can be started using
yarn dev:msw
where there is a check (Job name for http
) that provides an error for theTLSTargetCertificateCloseToExpiring
alert