-
Notifications
You must be signed in to change notification settings - Fork 20
feat: add TLS Cert Expiry alert for TCP checks #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since https://github.com/grafana/synthetic-monitoring-api/pull/1357 has been merged I've marked this as ready for review. However, I don't know if we want to include it in the public preview. Do we need to update the docs for it @ka3de? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'm not sure about the orange/warning color for the text.
Seems a bit much. Perhaps double check with @vesnadean ?
describe(`TCPCheck - Section 4 (Alerting) payload`, () => { | ||
it(`can add TLS certificate expiry alert when TLS is enabled`, async () => { | ||
jest.replaceProperty(config, 'featureToggles', { | ||
// @ts-expect-error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the error suppressions here and created a utility function to override feature flags in tests 👍
- also removes the need for TypeScript error suppression comments related to feature flag overrides
I see a couple options here:
|
…ring alerts in TCP checks
Thanks @vesnadean! I took another look, and since we don’t want to allow saving the alert when TLS is off, I went ahead and added a validation rule to handle that case, to be consistent with other invalid scenarios: Recording: This should help in cases where someone creates a check with the alert enabled and then later disables TLS by preventing that mismatch from being saved. If we’d rather not go with validation, we could fall back to just showing the message in a secondary color like you suggested: Let me know which alternative you think is best 🙏 |
@VikaCep The recording looks great, let's go with that option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏻
Closes #1149
Depends on https://github.com/grafana/synthetic-monitoring-api/pull/1357
Add "TLS Certificate Close to Expiring" Alert for TCP Checks
Summary
This PR introduces support for the "TLS certificate close to expiring" alert for TCP checks in the synthetic monitoring app.
Details
Feature:
UI/UX:
Tests:
Screen.Recording.2025-05-23.at.14.50.09.mov