Skip to content

fix: check type selector should be disabled on edit #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

rdubrock
Copy link
Contributor

@rdubrock rdubrock commented Sep 8, 2021

The check type input isn't getting disabled by the wrapping <Field> component for some reason. It shouldn't be possible to change the type of the check once it's been created, and it will cause the app to crash if someone does.

@rdubrock rdubrock requested a review from jewbetcha September 8, 2021 15:31
@rdubrock rdubrock requested a review from a team as a code owner September 8, 2021 15:31
@rdubrock rdubrock requested review from mem and removed request for a team and mem September 8, 2021 15:31
@rdubrock rdubrock merged commit dda165e into main Sep 8, 2021
@rdubrock rdubrock deleted the disable-check-type-on-edit branch September 8, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants