add test and fix test

Author: ie-pham

tempodb/encoding/vparquet3/block_traceql_meta_test.go

@@ -14,7 +14,7 @@ import (
 )
 
 func TestBackendBlockSearchFetchMetaData(t *testing.T) {
-	wantTr := fullyPopulatedTestTrace(nil)
+	wantTr := fullyPopulatedTestTraceWithOption(nil, true)
 	b := makeBackendBlockWithTraces(t, []*Trace{wantTr})
 	ctx := context.Background()
 

tempodb/encoding/vparquet3/block_traceql_test.go

@@ -391,11 +391,19 @@ func parse(t *testing.T, q string) traceql.Condition {
 }
 
 func fullyPopulatedTestTrace(id common.ID) *Trace {
+	return fullyPopulatedTestTraceWithOption(id, false)
+}
+
+func fullyPopulatedTestTraceWithOption(id common.ID, parentIDTest bool) *Trace {
 	// Helper functions to make pointers
 	strPtr := func(s string) *string { return &s }
 	intPtr := func(i int64) *int64 { return &i }
 	fltPtr := func(f float64) *float64 { return &f }
 	boolPtr := func(b bool) *bool { return &b }
+	parentID := []byte{}
+	if parentIDTest {
+		parentID = []byte("parentid")
+	}
 
 	links := tempopb.LinkSlice{
 		Links: []*v1.Span_Link{
@@ -463,7 +471,7 @@ func fullyPopulatedTestTrace(id common.ID) *Trace {
 								HttpMethod:             strPtr("get"),
 								HttpUrl:                strPtr("url/hello/world"),
 								HttpStatusCode:         intPtr(500),
-								ParentSpanID:           []byte("parentid"),
+								ParentSpanID:           parentID,
 								StatusCode:             int(v1.Status_STATUS_CODE_ERROR),
 								StatusMessage:          v1.Status_STATUS_CODE_ERROR.String(),
 								TraceState:             "tracestate",

tempodb/encoding/vparquet4/block_traceql_meta_test.go

@@ -14,7 +14,7 @@ import (
 )
 
 func TestBackendBlockSearchFetchMetaData(t *testing.T) {
-	wantTr := fullyPopulatedTestTrace(nil)
+	wantTr := fullyPopulatedTestTraceWithOption(nil, true)
 	b := makeBackendBlockWithTraces(t, []*Trace{wantTr})
 	ctx := context.Background()
 

tempodb/encoding/vparquet4/block_traceql_test.go

@@ -474,8 +474,16 @@ func parse(t *testing.T, q string) traceql.Condition {
 }
 
 func fullyPopulatedTestTrace(id common.ID) *Trace {
+	return fullyPopulatedTestTraceWithOption(id, false)
+}
+
+func fullyPopulatedTestTraceWithOption(id common.ID, parentIDTest bool) *Trace {
 	linkTraceID, _ := util.HexStringToTraceID("1234567890abcdef1234567890abcdef")
 	linkSpanID, _ := util.HexStringToSpanID("1234567890abcdef")
+	parentID := []byte{}
+	if parentIDTest {
+		parentID = []byte("parentid")
+	}
 
 	links := []Link{
 		{
@@ -562,7 +570,7 @@ func fullyPopulatedTestTrace(id common.ID) *Trace {
 								HttpMethod:             ptr("get"),
 								HttpUrl:                ptr("url/hello/world"),
 								HttpStatusCode:         ptr(int64(500)),
-								ParentSpanID:           []byte("parentid"),
+								ParentSpanID:           parentID,
 								StatusCode:             int(v1.Status_STATUS_CODE_ERROR),
 								StatusMessage:          v1.Status_STATUS_CODE_ERROR.String(),
 								TraceState:             "tracestate",
@@ -655,7 +663,6 @@ func fullyPopulatedTestTrace(id common.ID) *Trace {
 						Spans: []Span{
 							{
 								SpanID:                 []byte("spanid2"),
-								ParentSpanID:           []byte("parentid2"),
 								Name:                   "world",
 								StartTimeUnixNano:      uint64(200 * time.Second),
 								DurationNano:           uint64(200 * time.Second),

tempodb/tempodb_search_test.go

@@ -95,8 +95,13 @@ func traceQLRunner(t *testing.T, _ *tempopb.Trace, wantMeta *tempopb.TraceSearch
 		{Query: `{ ."res-dedicated.02" = "res-2a" }`},
 		{Query: `{ resource."k8s.namespace.name" = "k8sNamespace" }`},
 	}
+	parentID := util.SpanIDToHexString([]byte{4, 5, 6})
+	parentIDQuery := &tempopb.SearchRequest{
+		Query: fmt.Sprintf("{ span:parentID = %q }", parentID),
+	}
 
 	searchesThatMatch = append(searchesThatMatch, quotedAttributesThatMatch...)
+	searchesThatMatch = append(searchesThatMatch, parentIDQuery)
 	for _, req := range searchesThatMatch {
 		fetcher := traceql.NewSpansetFetcherWrapper(func(ctx context.Context, req traceql.FetchSpansRequest) (traceql.FetchSpansResponse, error) {
 			return r.Fetch(ctx, meta, req, common.DefaultSearchOptions())