Added a :patch option to allow reading patch data from a yaml file

Author: jdee

README.md

@@ -27,16 +27,35 @@ the action appends the specified text to the pattern match. It can also prepend
 the text or replace the pattern match with the text. Use an optional `:global`
 parameter to apply the patch to all instances of the regular expression.
 
+The `regexp`, `text`, `mode` and `global` options may be specified in a YAML file to
+define a patch, e.g.:
+
+```yaml
+regexp: '^\s*</application>'
+mode: "prepend"
+text: "        <meta-data android:name=\"foo\" android:value=\"bar\" />\n"
+global: false
+```
+
+```Ruby
+apply_patch file: "examples/PatchTestAndroid/app/src/main/AndroidManifest.xml",
+            patch: "patch.yaml"
+```
+
 ### Options
 
 |key|description|type|optional|default value|
 |---|-----------|----|--------|-------------|
 |:file|Absolute or relative path to a file to patch|String|no| |
-|:regexp|A regular expression to match|Regexp|no| |
-|:text|Text to append to the match|String|no| |
+|:regexp|A regular expression to match|Regexp|yes| |
+|:text|Text to append to the match|String|yes| |
 |:global|If true, patch all occurrences of the pattern|Boolean|yes|false|
 |:mode|:append, :prepend or :replace|Symbol|yes|:append|
 |:offset|Offset from which to start matching|Integer|yes|0|
+|:patch|A YAML file specifying patch data|String|yes| |
+
+The :regexp and :text options must be set either in a patch file specified using the
+:patch argument or via arguments in the Fastfile.
 
 ## Example
 

fastlane/Fastfile

@@ -1,6 +1,4 @@
 lane :test do
   apply_patch file: "examples/PatchTestAndroid/app/src/main/AndroidManifest.xml",
-              regexp: %r{^\s*</application>},
-              mode: :prepend,
-              text: "        <meta-data android:name=\"foo\" android:value=\"bar\" />\n"
+              patch: "patch.yaml"
 end

lib/fastlane/plugin/patch/actions/apply_patch_action.rb

@@ -1,7 +1,33 @@
+require 'yaml'
+
 module Fastlane
   module Actions
     class ApplyPatchAction < Action
       def self.run(params)
+        if params[:patch]
+          # raises
+          patch = YAML.load_file params[:patch]
+
+          # If the :patch option is present, load these params from the
+          # specified file. Action args override.
+          %w{regexp text mode global}.each do |option|
+            value = patch[option]
+            next if value.nil?
+
+            case option.to_sym
+            when :regexp
+              params[:regexp] = /#{value}/
+            when :mode
+              params[:mode] = value.to_sym
+            else
+              params[option.to_sym] = value
+            end
+          end
+        end
+
+        UI.user_error! "Must specify :regexp and :text either in a patch or via arguments" if
+          params[:regexp].nil? || params[:text].nil?
+
         helper = Fastlane::Helper::PatchHelper
         modified_contents = File.open(params[:file], "r") do |f|
           contents = f.read
@@ -43,11 +69,11 @@ def self.available_options
                                       type: String),
           FastlaneCore::ConfigItem.new(key: :regexp,
                                description: "A regular expression to match",
-                                  optional: false,
+                                  optional: true,
                                       type: Regexp),
           FastlaneCore::ConfigItem.new(key: :text,
                                description: "Text to append to the match",
-                                  optional: false,
+                                  optional: true,
                                       type: String),
           FastlaneCore::ConfigItem.new(key: :global,
                                description: "If true, patch all occurrences of the pattern",
@@ -63,7 +89,11 @@ def self.available_options
                                description: ":append, :prepend or :replace",
                                   optional: true,
                              default_value: :append,
-                                      type: Symbol)
+                                      type: Symbol),
+          FastlaneCore::ConfigItem.new(key: :patch,
+                               description: "A YAML file specifying patch data",
+                                  optional: true,
+                                      type: String)
         ]
       end
 

patch.yaml

@@ -0,0 +1,3 @@
+regexp: '^\s*</application>'
+mode: "prepend"
+text: "        <meta-data android:name=\"foo\" android:value=\"bar\" />\n"