Skip to content

Commit 69fb8d3

Browse files
authored
Fix deprecated comment for constants.QueueAnnotation (#1976)
1 parent df18528 commit 69fb8d3

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

‎.golangci.yaml‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ linters-settings:
1111
- assignOp
1212
- captLocal
1313
- commentFormatting
14-
- deprecatedComment
1514
- elseif
1615
- exitAfterDefer
1716
- ifElseChain
@@ -38,6 +37,12 @@ issues:
3837
# Which dirs to exclude: issues from them won't be reported
3938
exclude-dirs:
4039
- bin
40+
# Excluding configuration per-path, per-linter, per-text and per-source
41+
exclude-rules:
42+
- linters:
43+
- staticcheck
44+
# TODO(#768): Drop when incrementing the API version.
45+
text: "SA1019: constants.QueueAnnotation is deprecated"
4146
# Show all issues from a linter
4247
max-issues-per-linter: 0
4348
# Show all issues with the same text

‎pkg/controller/constants/constants.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ const (
2222

2323
// QueueAnnotation is the annotation key in the workload that holds the queue name.
2424
//
25-
// DEPRECATED: Use QueueLabel as a label key.
25+
// Deprecated: Use QueueLabel as a label key.
2626
QueueAnnotation = QueueLabel
2727

2828
// PrebuiltWorkloadLabel is the label key of the job holding the name of the pre-built workload to use.

0 commit comments

Comments
 (0)