refactoring the github workflow to pick up test coverage

Author: mccaffers

.github/workflows/sonarcloud.yml

@@ -64,9 +64,9 @@ jobs:
           OTHER_LDFLAGS="-L./external/libpqxx/build/src -lpqxx -lpq -L/opt/homebrew/Cellar/pkgconf/2.3.0_1/lib -L/opt/homebrew/Cellar/pkgconf/2.3.0_1/lib/pkgconfig -L/opt/homebrew/Cellar/postgresql@14/14.15/lib/postgresql@14 -L/opt/homebrew/Cellar/postgresql@14/14.15/lib/postgresql@14/pgxs -L/opt/homebrew/Cellar/postgresql@14/14.15/lib/postgresql@14/pkgconfig"
           clean build test  
           | xcpretty -r junit && exit ${PIPESTATUS[0]}
-    - name: Check artifacts
-          run: |
-            sh ./.github/workflows/cpp_coverage.sh
+    - name: Export coverage report
+        run: |
+          sh ./.github/workflows/cpp_coverage.sh
     # - name: Convert coverage report to sonarqube format
     #   run: >
     #       bash ./.github/workflows/xccov-to-sonarqube-generic.sh *.xcresult/ > sonarqube-generic-coverage.xml