azurebackup: fix mojibake chars (em dash/en dash/arrow -> ASCII) and restore DiskProtection recording

- Replace 90 Unicode characters (U+2014 em dash, U+2013 en dash, U+2192 right arrow)
  with ASCII equivalents across 22 .cs files per Jon's review feedback.
- Fix ProtectedItemProtect_DppVault_DiskProtection_Succeeds_E2E: add daily-retention-days
  parameter required by the new PolicyCreateValidator.
- Restore ProtectedItemProtect and VaultCreate_CreatesDppVault recordings from upstream
  tag (accidentally deleted/overwritten during previous asset push).
- Push corrected recordings as new asset tag.

Author: shrja-ms

tools/Azure.Mcp.Tools.AzureBackup/src/AzureBackupSetup.cs

@@ -59,53 +59,53 @@ public CommandGroup RegisterCommands(IServiceProvider serviceProvider)
     {
         var azureBackup = new CommandGroup(Name,
             """
-            Azure Backup operations – Unified commands to manage backup across Recovery Services vaults (RSV)
+            Azure Backup operations  -  Unified commands to manage backup across Recovery Services vaults (RSV)
             and Backup vaults (DPP/Data Protection). Supports vault management, protected item operations,
             policy management, job monitoring, recovery point browsing, governance, and disaster recovery.
             Use --vault-type to specify vault type or let the system auto-detect.
             """,
             Title);
 
-        var vault = new CommandGroup("vault", "Backup vault operations – Get vault details or list all vaults, create, and update vaults.");
+        var vault = new CommandGroup("vault", "Backup vault operations  -  Get vault details or list all vaults, create, and update vaults.");
         azureBackup.AddSubGroup(vault);
         RegisterCommand<VaultGetCommand>(serviceProvider, vault);
         RegisterCommand<VaultCreateCommand>(serviceProvider, vault);
         RegisterCommand<VaultUpdateCommand>(serviceProvider, vault);
 
-        var policy = new CommandGroup("policy", "Backup policy operations – Get policy details or list all policies, and create policies.");
+        var policy = new CommandGroup("policy", "Backup policy operations  -  Get policy details or list all policies, and create policies.");
         azureBackup.AddSubGroup(policy);
         RegisterCommand<PolicyGetCommand>(serviceProvider, policy);
         RegisterCommand<PolicyCreateCommand>(serviceProvider, policy);
 
-        var protectedItem = new CommandGroup("protecteditem", "Protected item operations – Get protected item details or list all, enable backup protection, and undelete soft-deleted items.");
+        var protectedItem = new CommandGroup("protecteditem", "Protected item operations  -  Get protected item details or list all, enable backup protection, and undelete soft-deleted items.");
         azureBackup.AddSubGroup(protectedItem);
         RegisterCommand<ProtectedItemGetCommand>(serviceProvider, protectedItem);
         RegisterCommand<ProtectedItemProtectCommand>(serviceProvider, protectedItem);
         RegisterCommand<ProtectedItemUndeleteCommand>(serviceProvider, protectedItem);
 
-        var protectableItem = new CommandGroup("protectableitem", "Protectable item operations – List discovered databases available for protection.");
+        var protectableItem = new CommandGroup("protectableitem", "Protectable item operations  -  List discovered databases available for protection.");
         azureBackup.AddSubGroup(protectableItem);
         RegisterCommand<ProtectableItemListCommand>(serviceProvider, protectableItem);
 
-        var backup = new CommandGroup("backup", "Backup operations – Check backup status for a datasource.");
+        var backup = new CommandGroup("backup", "Backup operations  -  Check backup status for a datasource.");
         azureBackup.AddSubGroup(backup);
         RegisterCommand<BackupStatusCommand>(serviceProvider, backup);
 
-        var job = new CommandGroup("job", "Backup job operations – Get job details or list all jobs in a vault.");
+        var job = new CommandGroup("job", "Backup job operations  -  Get job details or list all jobs in a vault.");
         azureBackup.AddSubGroup(job);
         RegisterCommand<JobGetCommand>(serviceProvider, job);
 
-        var recoveryPoint = new CommandGroup("recoverypoint", "Recovery point operations – Get recovery point details or list all for a protected item.");
+        var recoveryPoint = new CommandGroup("recoverypoint", "Recovery point operations  -  Get recovery point details or list all for a protected item.");
         azureBackup.AddSubGroup(recoveryPoint);
         RegisterCommand<RecoveryPointGetCommand>(serviceProvider, recoveryPoint);
 
-        var governance = new CommandGroup("governance", "Governance operations – Find unprotected resources, configure immutability and soft delete.");
+        var governance = new CommandGroup("governance", "Governance operations  -  Find unprotected resources, configure immutability and soft delete.");
         azureBackup.AddSubGroup(governance);
         RegisterCommand<GovernanceFindUnprotectedCommand>(serviceProvider, governance);
         RegisterCommand<GovernanceImmutabilityCommand>(serviceProvider, governance);
         RegisterCommand<GovernanceSoftDeleteCommand>(serviceProvider, governance);
 
-        var disasterrecovery = new CommandGroup("disasterrecovery", "Disaster recovery operations – Enable Cross-Region Restore on a GRS vault.");
+        var disasterrecovery = new CommandGroup("disasterrecovery", "Disaster recovery operations  -  Enable Cross-Region Restore on a GRS vault.");
         azureBackup.AddSubGroup(disasterrecovery);
         RegisterCommand<DisasterRecoveryEnableCrrCommand>(serviceProvider, disasterrecovery);
 

tools/Azure.Mcp.Tools.AzureBackup/src/Models/ProtectResult.cs

@@ -20,12 +20,12 @@ namespace Azure.Mcp.Tools.AzureBackup.Models;
 /// </param>
 /// <param name="JobId">
 /// RSV ConfigureBackup job id (use with <c>azurebackup job get</c>). Always
-/// <c>null</c> for DPP — DPP protection is not surfaced as a job; verify with
+/// <c>null</c> for DPP  -  DPP protection is not surfaced as a job; verify with
 /// <c>azurebackup protecteditem get</c> or <c>list</c>.
 /// </param>
 /// <param name="Message">Human-readable summary of the outcome.</param>
 /// <param name="ProtectionStatus">
-/// DPP only — actual <c>protectionStatus.status</c> read back from the backup
+/// DPP only  -  actual <c>protectionStatus.status</c> read back from the backup
 /// instance after the operation (e.g. <c>ProtectionConfigured</c>,
 /// <c>ConfiguringProtection</c>, <c>ProtectionError</c>).
 /// </param>

tools/Azure.Mcp.Tools.AzureBackup/src/Options/AzureBackupOptionDefinitions.cs

@@ -29,7 +29,7 @@ public static class AzureBackupOptionDefinitions
     public const string ResourceTypeFilterName = "resource-type-filter";
     public const string TagFilterName = "tag-filter";
 
-    // Policy create — common schedule flags (new in policy create overhaul)
+    // Policy create  -  common schedule flags (new in policy create overhaul)
     public const string TimeZoneName = "time-zone";
     public const string ScheduleFrequencyName = "schedule-frequency";
     public const string ScheduleTimesName = "schedule-times";
@@ -38,7 +38,7 @@ public static class AzureBackupOptionDefinitions
     public const string HourlyWindowStartTimeName = "hourly-window-start-time";
     public const string HourlyWindowDurationHoursName = "hourly-window-duration-hours";
 
-    // Policy create — retention flags (new in policy create overhaul)
+    // Policy create  -  retention flags (new in policy create overhaul)
     public const string WeeklyRetentionWeeksName = "weekly-retention-weeks";
     public const string WeeklyRetentionDaysOfWeekName = "weekly-retention-days-of-week";
     public const string MonthlyRetentionMonthsName = "monthly-retention-months";
@@ -53,13 +53,13 @@ public static class AzureBackupOptionDefinitions
     public const string ArchiveTierAfterDaysName = "archive-tier-after-days";
     public const string ArchiveTierModeName = "archive-tier-mode";
 
-    // Policy create — RSV-VM only flags
+    // Policy create  -  RSV-VM only flags
     public const string PolicySubTypeName = "policy-sub-type";
     public const string InstantRpRetentionDaysName = "instant-rp-retention-days";
     public const string InstantRpResourceGroupName = "instant-rp-resource-group";
     public const string SnapshotConsistencyName = "snapshot-consistency";
 
-    // Policy create — RSV-VmWorkload (SQL / SAPHANA / SAPASE) flags
+    // Policy create  -  RSV-VmWorkload (SQL / SAPHANA / SAPASE) flags
     public const string FullScheduleFrequencyName = "full-schedule-frequency";
     public const string FullScheduleDaysOfWeekName = "full-schedule-days-of-week";
     public const string DifferentialScheduleDaysOfWeekName = "differential-schedule-days-of-week";
@@ -71,7 +71,7 @@ public static class AzureBackupOptionDefinitions
     public const string IsCompressionName = "is-compression";
     public const string IsSqlCompressionName = "is-sql-compression";
 
-    // Policy create — Stage 2 expansion flags
+    // Policy create  -  Stage 2 expansion flags
     // RSV VM Smart Tier (ML-based archive recommendation)
     public const string SmartTierName = "smart-tier";
     // RSV SAPHANA snapshot/instance backups
@@ -441,7 +441,7 @@ public static class AzureBackupOptionDefinitions
 
     public static readonly Option<string> SmartTier = new($"--{SmartTierName}")
     {
-        Description = "Enable smart-tiering (ML-based archive recommendation): 'true' or 'false'. RSV VM only — equivalent to TieringMode=TierRecommended.",
+        Description = "Enable smart-tiering (ML-based archive recommendation): 'true' or 'false'. RSV VM only  -  equivalent to TieringMode=TierRecommended.",
         Required = false
     };
 

tools/Azure.Mcp.Tools.AzureBackup/src/Services/AzureBackupService.cs

@@ -671,12 +671,12 @@ private static async Task<T> AutoDetectAndExecuteAsync<T>(
         }
         catch (RequestFailedException ex) when (ex.Status is 401 or 403)
         {
-            // RSV auth failure — try DPP before giving up
+            // RSV auth failure  -  try DPP before giving up
             rsvAuthFailed = true;
         }
         catch (RequestFailedException ex) when (ex.Status is 404)
         {
-            // RSV not found — try DPP
+            // RSV not found  -  try DPP
         }
 
         try

tools/Azure.Mcp.Tools.AzureBackup/src/Services/DppBackupOperations.cs

@@ -19,8 +19,8 @@ public sealed class DppBackupOperations(ITenantService tenantService) : BaseAzur
 
     /// <summary>
     /// Resolves the DPP datasource profile from a user-supplied or auto-detected type string.
-    /// Handles auto-detection (e.g. "Microsoft.Storage/storageAccounts" → Blob profile)
-    /// and friendly name mapping (e.g. "aks" → AKS profile).
+    /// Handles auto-detection (e.g. "Microsoft.Storage/storageAccounts" -> Blob profile)
+    /// and friendly name mapping (e.g. "aks" -> AKS profile).
     /// </summary>
     internal static DppDatasourceProfile ResolveProfile(string datasourceTypeOrArm)
     {
@@ -280,7 +280,7 @@ public async Task<ProtectedItemInfo> GetProtectedItemAsync(
         }
         catch (RequestFailedException ex) when (ex.Status == 404)
         {
-            // Direct lookup failed — search by friendly/datasource name
+            // Direct lookup failed  -  search by friendly/datasource name
         }
 
         // Fall back to listing all items and searching by friendly name

tools/Azure.Mcp.Tools.AzureBackup/src/Services/DppDatasourceProfile.cs

@@ -14,7 +14,7 @@ public enum DppDataSourceSetMode
     /// <summary>DataSourceSetInfo points to the datasource itself (AKS).</summary>
     Self,
 
-    /// <summary>DataSourceSetInfo points to the parent resource (ESAN volume group → parent ESAN).</summary>
+    /// <summary>DataSourceSetInfo points to the parent resource (ESAN volume group -> parent ESAN).</summary>
     Parent,
 }
 
@@ -63,7 +63,7 @@ public enum DppBackupParametersMode
 /// Each property drives a specific dimension of protect, policy-create, and restore operations.
 /// </summary>
 /// <remarks>
-/// AOT-safe: no reflection, no Func delegates — pure data record with enum-driven dispatch.
+/// AOT-safe: no reflection, no Func delegates  -  pure data record with enum-driven dispatch.
 ///
 /// === Policy Create - Staged Implementation Plan ===
 ///
@@ -104,7 +104,7 @@ public sealed record DppDatasourceProfile
     public bool UsesOperationalStore { get; init; }
 
 
-    /// <summary>True for continuous backup (Blob, ADLS) — no scheduled backup rule created.</summary>
+    /// <summary>True for continuous backup (Blob, ADLS)  -  no scheduled backup rule created.</summary>
     public bool IsContinuousBackup { get; init; }
 
     /// <summary>ISO 8601 schedule interval (e.g. "PT4H", "P1D"). Ignored when <see cref="IsContinuousBackup"/> is true.</summary>
@@ -140,7 +140,7 @@ public sealed record DppDatasourceProfile
     /// <summary>
     /// If non-null, when the user's resource ID matches this base ARM type (e.g. "Microsoft.Storage/storageAccounts"),
     /// automatically re-map to this profile's <see cref="ArmResourceType"/>.
-    /// Used for Blob (storage account → blobServices) auto-detection.
+    /// Used for Blob (storage account -> blobServices) auto-detection.
     /// </summary>
     public string? AutoDetectFromBaseResourceType { get; init; }
 

tools/Azure.Mcp.Tools.AzureBackup/src/Services/DppDatasourceRegistry.cs

@@ -13,7 +13,7 @@ namespace Azure.Mcp.Tools.AzureBackup.Services;
 /// To add a new DPP datasource type:
 ///   1. Add a static DppDatasourceProfile instance below
 ///   2. Register it in the AllProfiles array
-///   — No other code changes needed in DppBackupOperations.
+///    -  No other code changes needed in DppBackupOperations.
 /// </summary>
 public static class DppDatasourceRegistry
 {
@@ -193,7 +193,7 @@ public static DppDatasourceProfile Resolve(string workloadTypeOrArmType)
     /// <summary>
     /// Tries to auto-detect a profile when the user supplies a base resource type
     /// (e.g. "Microsoft.Storage/storageAccounts") that needs re-mapping to a child type
-    /// (e.g. Blob → "Microsoft.Storage/storageAccounts/blobServices").
+    /// (e.g. Blob -> "Microsoft.Storage/storageAccounts/blobServices").
     /// </summary>
     public static DppDatasourceProfile? TryAutoDetect(string armResourceType)
     {
@@ -212,7 +212,7 @@ public static DppDatasourceProfile Resolve(string workloadTypeOrArmType)
     }
 
     /// <summary>
-    /// Derives the parent resource ID from a child resource ID (e.g. ESAN volume group → parent ESAN).
+    /// Derives the parent resource ID from a child resource ID (e.g. ESAN volume group -> parent ESAN).
     /// Generic logic that strips the last two path segments (/childType/childName).
     /// </summary>
     public static ResourceIdentifier GetParentResourceId(ResourceIdentifier childResourceId)

tools/Azure.Mcp.Tools.AzureBackup/src/Services/Policy/DppPolicyBuilder.cs

@@ -12,7 +12,7 @@ namespace Azure.Mcp.Tools.AzureBackup.Services.Policy;
 /// </summary>
 /// <remarks>
 /// AOT-safe: no reflection, no dynamic dispatch.
-/// All inputs are nullable strings — when a flag is omitted the builder falls back
+/// All inputs are nullable strings  -  when a flag is omitted the builder falls back
 /// to the long-standing default behavior so existing minimal-flag invocations keep
 /// working unchanged.
 /// Multi-tier retention is opt-in: when <c>--weekly-retention-weeks</c>,
@@ -38,7 +38,7 @@ public static RuleBasedBackupPolicy Build(PolicyCreateRequest request, DppDataso
         var isContinuous = profile.IsContinuousBackup && !isVaultedMode;
 
         // For vaulted storage workloads (Blob/ADLS Vaulted mode), the policy is driven entirely
-        // by VaultStore retention rules — no AzureBackupRule (the trigger is implicit, managed by
+        // by VaultStore retention rules  -  no AzureBackupRule (the trigger is implicit, managed by
         // the storage platform). This matches the Az CLI shape and is what the DPP service accepts.
         var isVaultedStorage = isVaultedMode && profile.IsContinuousBackup;
 
@@ -62,7 +62,7 @@ public static RuleBasedBackupPolicy Build(PolicyCreateRequest request, DppDataso
 
         // Per-tier retention rules (opt-in via positive weeks/months/years).
         // When vault-tier copy is enabled on an operational-store workload (e.g. AzureDisk), the
-        // per-tier rules MUST source from VaultStore — the operational (snapshot) tier on AzureDisk
+        // per-tier rules MUST source from VaultStore  -  the operational (snapshot) tier on AzureDisk
         // does not accept multi-tier (weekly/monthly/yearly) retention rules. The matching tagging
         // criteria on the AzureBackupRule lifecycle direct the service to copy tagged RPs to vault.
         var tierStore = vaultTierEnabled ? DataStoreType.VaultStore : dataStoreType;

tools/Azure.Mcp.Tools.AzureBackup/src/Services/Policy/PolicyCreateRequest.cs

@@ -10,7 +10,7 @@ namespace Azure.Mcp.Tools.AzureBackup.Services.Policy;
 /// passed as separate parameters to the service methods.
 /// </summary>
 /// <remarks>
-/// All fields are nullable strings — the service layer is responsible for parsing,
+/// All fields are nullable strings  -  the service layer is responsible for parsing,
 /// validating, and translating them into SDK objects via the policy builders.
 /// This decoupling keeps the System.CommandLine option-binding concerns out of the
 /// service layer and makes builder unit tests easy to write.