Add loglimit to log provider

Author: giongto35

opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py

@@ -157,7 +157,7 @@ def _from_env_if_absent(
         cls, value: int | None, env_var: str, default: int | None = None
     ) -> int | None:
         if value == cls.UNSET:
-            return None
+            value = None  # continue to read the limit from env
 
         err_msg = "{} must be a non-negative integer but got {}"
 
@@ -556,7 +556,6 @@ def __init__(
     ) -> None:
         super().__init__(level=level)
         self._logger_provider = logger_provider or get_logger_provider()
-        self._log_limits = LogLimits()
 
     @staticmethod
     def _get_attributes(record: logging.LogRecord) -> _ExtendedAttributes:
@@ -630,7 +629,7 @@ def _translate(self, record: logging.LogRecord) -> LogRecord:
             body=body,
             resource=logger.resource,
             attributes=attributes,
-            limits=self._log_limits,
+            limits=self._logger_provider._log_limits,
         )
 
     def emit(self, record: logging.LogRecord) -> None:
@@ -693,6 +692,7 @@ def __init__(
         multi_log_record_processor: SynchronousMultiLogRecordProcessor
         | ConcurrentMultiLogRecordProcessor
         | None = None,
+        log_limits: LogLimits | None = _UnsetLogLimits,
     ):
         if resource is None:
             self._resource = Resource.create({})
@@ -708,6 +708,7 @@ def __init__(
             self._at_exit_handler = atexit.register(self.shutdown)
         self._logger_cache = {}
         self._logger_cache_lock = Lock()
+        self._log_limits = log_limits
 
     @property
     def resource(self):

opentelemetry-sdk/tests/logs/test_handler.py

@@ -426,33 +426,6 @@ def test_otel_attribute_count_limit_includes_code_attributes(self):
             f"Should have 6 dropped attributes, got {log_record.dropped_attributes}",
         )
 
-    @patch.dict(os.environ, {OTEL_ATTRIBUTE_COUNT_LIMIT: "0"})
-    def test_otel_attribute_count_limit_zero_prevents_all_attributes(self):
-        """Test that OTEL_ATTRIBUTE_COUNT_LIMIT=0 prevents all attributes."""
-        processor, logger = set_up_test_logging(logging.WARNING)
-
-        # Create a log record with extra attributes
-        extra_attrs = {"user_attr": "value", "another_attr": "another_value"}
-
-        with self.assertLogs(level=logging.WARNING):
-            logger.warning("Test message", extra=extra_attrs)
-
-        log_record = processor.get_log_record(0)
-
-        # With OTEL_ATTRIBUTE_COUNT_LIMIT=0, should have 0 attributes
-        self.assertEqual(
-            len(log_record.attributes),
-            0,
-            "With OTEL_ATTRIBUTE_COUNT_LIMIT=0, should have no attributes",
-        )
-
-        # Should have 5 dropped attributes (2 user + 3 code = 5 dropped)
-        self.assertEqual(
-            log_record.dropped_attributes,
-            5,
-            f"Should have 5 dropped attributes, got {log_record.dropped_attributes}",
-        )
-
     def test_logging_handler_without_env_var_uses_default_limit(self):
         """Test that without OTEL_ATTRIBUTE_COUNT_LIMIT, default limit (128) should apply."""
         processor, logger = set_up_test_logging(logging.WARNING)