Use two-dot instead of three-dot diffs #147561
Replies: 1 comment
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Select Topic Area
Product Feedback
Body
This was raised on the old community-maintained issue tracker here: isaacs/github#750 (comment)
Additionally AzDO has a similar request out: https://developercommunity.visualstudio.com/t/pull-request-diff-show-actual-diff-instead-of-comm/1065332
As mentioned in that comment - having the wrong diff shown can lead to production outages
I notice this page explaining what github does:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-comparing-branches-in-pull-requests#three-dot-and-two-dot-git-diff-comparisons
That's not true at all - the NET change after the pull request is merged is the two-dot diff. To me it seems that it's cheaper / easier to implement 3-dot diffs as one only needs to recompute the diff if there is a push to the source branch, rather than the target branch.
Can we please at least have the option to show the two-dot diff?
Beta Was this translation helpful? Give feedback.
All reactions