ARC Community Feedback: Secret storage requirements

[Steve-Glass]

👋 I'm @Steve-Glass a Product Manager with GitHub Actions and starting to taking a deeper look into ARC. Developers have been reaching out and asking for ARC integrations with secret store cloud providers such as Azure Key Vault, Hashicorp Vault, and AWS Key Management Service. The requirement of the integration is to pull the Personal Access Token (PAT) or GitHub App private key from the key management service as opposed to etcd.

I would appreciate any feedback the community has on this topic as we start scoping out the next set of features for ARC. Does your organization require integration between ARC and cloud-based secret stores? If yes, which provider are you looking to integrate with?

TIA!

[houserx-jmcc]

Does your organization require integration between ARC and cloud-based secret stores? If yes, which provider are you looking to integrate with?

Yup! It would be great to be able to hook directly into AWS Secrets Manager or AWS Systems Manager for pulling a PAT/key. That is the standard place we store secrets for literally everything else, and would make ARC easier to manage overall.

[Steve-Glass]

Thank you for the feedback!

[eremeevfd]

We would be happy to have integration with HashiCorp Vault. But could you explain to me a little bit, this integration with cloud-based secret provider, is it for fetching secrets in workflows and their jobs themselves? Or is it just for runner configuration?

[Steve-Glass]

👋 The purpose of this is solely to retrieve the secrets required for configuring ARC. It will not have any impact on how secrets are managed or utilized during a workflow run.

[blackliner]

I think the canonical approach is to use the External Secrets Operator, which decouples the secret storage from this application

[julian-waibel]

Currently I do it like already stated by @blackliner: Install and configure External Secrets Operator in the cluster using Argo CD. The operator then "syncs" the external secrets (e.g. from Azure Key Vault or HashiCorp Vault) into the cluster creating a local Kubernetes native secret. This secret (name) can then be referenced in the GitHub ARC scale set Helm chart using the githubConfigSecret Helm value as can be seen in the following. Therefore @Steve-Glass I don't see an added value to implement this feature into the GitHub ARC project. The operator already does a very good job.

https://github.com/actions/actions-runner-controller/blob/894732732a5a414deea5e47c9793caaa05d641b4/charts/gha-runner-scale-set/values.yaml#L15-L17

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐