[Feature Request] Support AND Logic in CODEOWNERS for Required Approvals #166110
Replies: 5 comments
-
|
This is very much needed. |
Beta Was this translation helpful? Give feedback.
-
|
This would be very helpful to our workflow. Good request, very well-written. |
Beta Was this translation helpful? Give feedback.
-
|
This is needed |
Beta Was this translation helpful? Give feedback.
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
-
|
This would be very much appreciated feature. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Select Topic Area
Product Feedback
Body
Currently, GitHub’s CODEOWNERS file only supports OR logic for required reviewers. For example, specifying:
means that a pull request affecting these files requires approval from either
@owner1or@owner2. Firstly, am I misunderstanding this? If not ↓Feature Request:
I would like to request support for an AND logic in CODEOWNERS, so that it is possible to require approvals from multiple specific owners for a given path.
Proposed Syntax Examples:
/path/to/files/ (@owner1 @owner2)→ Requires approval from both
@owner1and@owner2./path/to/files/ (@owner1 @owner2) @owner3→ Requires approval from both
@owner1and@owner2, or approval from@owner3.This would allow for more flexible and secure code review workflows, ensuring that files can only be merged when all designated owners have approved.
Summary Table:
/path/to/files/ @owner1 @owner2@owner1or@owner2@owner1or@owner2(unchanged)/path/to/files/ (@owner1 @owner2)@owner1and@owner2/path/to/files/ (@owner1 @owner2) @owner3@owner1and@owner2) or@owner3Thoughts?
Beta Was this translation helpful? Give feedback.
All reactions